binding: Compiles event handlers only once at most.

binding: Compiles event handlers only once if not compilable.

Blink no longer compiles a script for an event handler twice
or more if the script is not compilable.

BUG=597900
Committed: https://crrev.com/2fb386fd03fc84f7ba3a72417bc2345ad6f308c4
Cr-Commit-Position: refs/heads/master@{#408638}

[Yuki, 2016-07-27 14:21:21]

The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 14:21:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuki, 2016-07-27 14:21:55]

yukishiino@chromium.org changed reviewers:
+ haraken@chromium.org

[Yuki, 2016-07-27 14:21:55]

Could you review this CL?

[haraken, 2016-07-27 14:30:17]

This CL looks mostly correct, but I'd prefer stop re-compiling the listener
function only when prepareListenerObject() has failed because the script compile
has failed. When prepareListenerObject() has failed for other reasons, I think
it's better to retry compiling.

https://codereview.chromium.org/2190553003/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp (right):

https://codereview.chromium.org/2190553003/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp:131: if
(!toDocument(executionContext)->allowInlineEventHandler(m_node, this,
m_sourceURL, m_position.m_line)) {

For example, if we have reached this block and failed at compiling the listener
function, I think we should retry compiling the second time the listener object
is requested.

https://codereview.chromium.org/2190553003/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp:171: if
(block.HasCaught()) {

What we really do is that we stop compiling the listener function if we have
reached this block.

[commit-bot: I haz the power, 2016-07-27 15:33:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 15:33:18]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Yuki, 2016-07-29 13:54:56]

The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 13:55:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuki, 2016-07-29 15:11:27]

You were right.  Also I needed to fix the code to pass the layout tests.

Could you take another look?

[Yuki, 2016-07-29 15:12:43]

Description was changed from

==========
binding: Compiles event handlers only once at most.

Blink no longer compiles scripts for event handlers twice or more.
It compiles only once at most.

BUG=597900
==========

to

==========
binding: Compiles event handlers only once if not compilable.

Blink no longer compiles a script for an event handler twice
or more if the script is not compilable.

BUG=597900
==========

[haraken, 2016-07-29 15:15:50]

LGTM

[Yuki, 2016-07-29 15:18:21]

The CQ bit was unchecked by yukishiino@chromium.org

[Yuki, 2016-07-29 15:18:28]

The CQ bit was checked by yukishiino@chromium.org

[commit-bot: I haz the power, 2016-07-29 15:18:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 15:21:51]

Description was changed from

==========
binding: Compiles event handlers only once if not compilable.

Blink no longer compiles a script for an event handler twice
or more if the script is not compilable.

BUG=597900
==========

to

==========
binding: Compiles event handlers only once if not compilable.

Blink no longer compiles a script for an event handler twice
or more if the script is not compilable.

BUG=597900
==========

[commit-bot: I haz the power, 2016-07-29 15:21:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-29 15:24:17]

Description was changed from

==========
binding: Compiles event handlers only once if not compilable.

Blink no longer compiles a script for an event handler twice
or more if the script is not compilable.

BUG=597900
==========

to

==========
binding: Compiles event handlers only once if not compilable.

Blink no longer compiles a script for an event handler twice
or more if the script is not compilable.

BUG=597900

Committed: https://crrev.com/2fb386fd03fc84f7ba3a72417bc2345ad6f308c4
Cr-Commit-Position: refs/heads/master@{#408638}
==========

[commit-bot: I haz the power, 2016-07-29 15:24:18]

Patchset 2 (id:??) landed as
https://crrev.com/2fb386fd03fc84f7ba3a72417bc2345ad6f308c4
Cr-Commit-Position: refs/heads/master@{#408638}