Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.h

Issue 2190553003: binding: Compiles event handlers only once at most. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed a lot of things. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.h b/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.h
index 3e877f93d9b83511816b6fa77cd1682c01653e6a..576e9c0ffff2f223818959b4d29468b9b385660a 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.h
@@ -59,7 +59,7 @@ public:
const String& code() const { return m_code; }
protected:
- void prepareListenerObject(ExecutionContext*) override;
+ v8::Local<v8::Object> getListenerObjectInternal(ExecutionContext*) override;
private:
V8LazyEventListener(v8::Isolate*, const AtomicString& functionName, const AtomicString& eventParameterName, const String& code, const String sourceURL, const TextPosition&, Node*);
@@ -72,8 +72,11 @@ private:
// SVGUseElement::transferEventListenersToShadowTree
bool wasCreatedFromMarkup() const override { return true; }
+ void compileScript(ScriptState*, ExecutionContext*);
+
void fireErrorEvent(v8::Local<v8::Context>, ExecutionContext*, v8::Local<v8::Message>);
+ bool m_wasCompilationFailed;
AtomicString m_functionName;
AtomicString m_eventParameterName;
String m_code;

Powered by Google App Engine
This is Rietveld 408576698