ImageCapture: content_browsertest WebRtcImageCaptureBrowserTest CreateAndGetCapabilities

ImageCapture: add WebRtcImageCaptureBrowserTest content_browsertest

This CL adds a content_browsertest for ImageCapture:
WebRtcImageCaptureBrowserTest, with one test case,
CreateAndGetCapabilities, that is parameterized to
exercise the FakeVideoCaptureDevice and, in the very
near future, the system's device if implemented
(i.e., Android).

WebRtcImageCaptureBrowserTest needs access to the
physical webcam, but in general content_browsertests
are always using the Fake. WebRtcWebcamBrowserTest has
the necessary infrastructure to do this, so it's made
public and reused as base class for the former.

Also, this CL moves
 content/test/webrtc_content_browsertest_base.{cc,h}
to
 content/browser/media/webrtc/
since they are purely internal to content_browsertests.

BUG=627537, 518807
TEST=new content_browsertests
WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0
 (all platforms)

Committed: https://crrev.com/13c7a2dfcd26e94f607a169de86b937fa21fb236
Cr-Commit-Position: refs/heads/master@{#408690}

[mcasas, 2016-07-27 22:15:30]

Description was changed from

==========
ImageCapture: content_browsertest WebRtcImageCaptureBrowserTest
CreateAndGetCapabilities

BUG=627537, 518807
==========

to

==========
ImageCapture: content_browsertest WebRtcImageCaptureBrowserTest
CreateAndGetCapabilities

This CL adds a content_browsertest for ImageCapture,
WebRtcImageCaptureBrowserTest, with one test case :
CreateAndGetCapabilities, that is parameterized to 
exercise the FakeVideoCaptureDevice and the system's
device if implemented (i.e., Android).

WebRtcImageCaptureBrowserTest needs access to the 
physical webcam, but in general content_browsertests
are always using the Fake. WebRtcWebcamBrowserTest has
the necessary infrastructure to do this, so its 
made public and reused as base class for the former.

BUG=627537, 518807
==========

[mcasas, 2016-07-27 22:45:34]

Description was changed from

==========
ImageCapture: content_browsertest WebRtcImageCaptureBrowserTest
CreateAndGetCapabilities

This CL adds a content_browsertest for ImageCapture,
WebRtcImageCaptureBrowserTest, with one test case :
CreateAndGetCapabilities, that is parameterized to 
exercise the FakeVideoCaptureDevice and the system's
device if implemented (i.e., Android).

WebRtcImageCaptureBrowserTest needs access to the 
physical webcam, but in general content_browsertests
are always using the Fake. WebRtcWebcamBrowserTest has
the necessary infrastructure to do this, so its 
made public and reused as base class for the former.

BUG=627537, 518807
==========

to

==========
ImageCapture: content_browsertest WebRtcImageCaptureBrowserTest
CreateAndGetCapabilities

This CL adds a content_browsertest for ImageCapture,
WebRtcImageCaptureBrowserTest, with one test case :
CreateAndGetCapabilities, that is parameterized to 
exercise the FakeVideoCaptureDevice and the system's
device if implemented (i.e., Android).

WebRtcImageCaptureBrowserTest needs access to the 
physical webcam, but in general content_browsertests
are always using the Fake. WebRtcWebcamBrowserTest has
the necessary infrastructure to do this, so its 
made public and reused as base class for the former.

Also, this CL moves 
 content/test/webrtc_content_browsertest_base.{cc,h} 
to 
 content/browser/media/webrtc/
since they are purely internal to content_browsertests.

BUG=627537, 518807
==========

[mcasas, 2016-07-27 23:36:55]

Description was changed from

==========
ImageCapture: content_browsertest WebRtcImageCaptureBrowserTest
CreateAndGetCapabilities

This CL adds a content_browsertest for ImageCapture,
WebRtcImageCaptureBrowserTest, with one test case :
CreateAndGetCapabilities, that is parameterized to 
exercise the FakeVideoCaptureDevice and the system's
device if implemented (i.e., Android).

WebRtcImageCaptureBrowserTest needs access to the 
physical webcam, but in general content_browsertests
are always using the Fake. WebRtcWebcamBrowserTest has
the necessary infrastructure to do this, so its 
made public and reused as base class for the former.

Also, this CL moves 
 content/test/webrtc_content_browsertest_base.{cc,h} 
to 
 content/browser/media/webrtc/
since they are purely internal to content_browsertests.

BUG=627537, 518807
==========

to

==========
ImageCapture: add WebRtcImageCaptureBrowserTest content_browsertest

This CL adds a content_browsertest for ImageCapture,
WebRtcImageCaptureBrowserTest, with one test case :
CreateAndGetCapabilities, that is parameterized to 
exercise the FakeVideoCaptureDevice and the system's
device if implemented (i.e., Android).

WebRtcImageCaptureBrowserTest needs access to the 
physical webcam, but in general content_browsertests
are always using the Fake. WebRtcWebcamBrowserTest has
the necessary infrastructure to do this, so its 
made public and reused as base class for the former.

Also, this CL moves 
 content/test/webrtc_content_browsertest_base.{cc,h} 
to 
 content/browser/media/webrtc/
since they are purely internal to content_browsertests.

BUG=627537, 518807
TEST=new content_browsertests 
WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0
 (all platforms)
WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/1
 (android with webcam)
==========

[mcasas, 2016-07-27 23:39:57]

Description was changed from

==========
ImageCapture: add WebRtcImageCaptureBrowserTest content_browsertest

This CL adds a content_browsertest for ImageCapture,
WebRtcImageCaptureBrowserTest, with one test case :
CreateAndGetCapabilities, that is parameterized to 
exercise the FakeVideoCaptureDevice and the system's
device if implemented (i.e., Android).

WebRtcImageCaptureBrowserTest needs access to the 
physical webcam, but in general content_browsertests
are always using the Fake. WebRtcWebcamBrowserTest has
the necessary infrastructure to do this, so its 
made public and reused as base class for the former.

Also, this CL moves 
 content/test/webrtc_content_browsertest_base.{cc,h} 
to 
 content/browser/media/webrtc/
since they are purely internal to content_browsertests.

BUG=627537, 518807
TEST=new content_browsertests 
WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0
 (all platforms)
WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/1
 (android with webcam)
==========

to

==========
ImageCapture: add WebRtcImageCaptureBrowserTest content_browsertest

This CL adds a content_browsertest for ImageCapture:
WebRtcImageCaptureBrowserTest, with one test case,
CreateAndGetCapabilities, that is parameterized to 
exercise the FakeVideoCaptureDevice and the system's
device if implemented (i.e., Android).

WebRtcImageCaptureBrowserTest needs access to the 
physical webcam, but in general content_browsertests
are always using the Fake. WebRtcWebcamBrowserTest has
the necessary infrastructure to do this, so its 
made public and reused as base class for the former.

Also, this CL moves 
 content/test/webrtc_content_browsertest_base.{cc,h} 
to 
 content/browser/media/webrtc/
since they are purely internal to content_browsertests.

BUG=627537, 518807
TEST=new content_browsertests 
WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0
 (all platforms)
WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/1
 (android with webcam)
==========

[mcasas, 2016-07-27 23:40:13]

Patchset #2 (id:20001) has been deleted

[mcasas, 2016-07-27 23:40:22]

Patchset #1 (id:1) has been deleted

[mcasas, 2016-07-27 23:40:49]

mcasas@chromium.org changed reviewers:
+ phoglund@chromium.org

[mcasas, 2016-07-27 23:40:50]

phoglund@ PTAL

[mcasas, 2016-07-28 00:31:10]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 00:31:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 01:25:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 01:25:27]

Dry run: This issue passed the CQ dry run.

[phoglund_chromium, 2016-07-28 14:07:50]

https://codereview.chromium.org/2190523004/diff/60001/content/test/data/media...
File content/test/data/media/image_capture_test.html (right):

https://codereview.chromium.org/2190523004/diff/60001/content/test/data/media...
content/test/data/media/image_capture_test.html:39: // construction in its own
thread. Need to wait yikes!
This _will_ be flaky.

I recommend you write this to retry on err instead. Basically just keep retrying
until it succeeds.

[mcasas, 2016-07-28 22:59:08]

Patchset #3 (id:80001) has been deleted

[mcasas, 2016-07-28 23:22:43]

Description was changed from

==========
ImageCapture: add WebRtcImageCaptureBrowserTest content_browsertest

This CL adds a content_browsertest for ImageCapture:
WebRtcImageCaptureBrowserTest, with one test case,
CreateAndGetCapabilities, that is parameterized to 
exercise the FakeVideoCaptureDevice and the system's
device if implemented (i.e., Android).

WebRtcImageCaptureBrowserTest needs access to the 
physical webcam, but in general content_browsertests
are always using the Fake. WebRtcWebcamBrowserTest has
the necessary infrastructure to do this, so its 
made public and reused as base class for the former.

Also, this CL moves 
 content/test/webrtc_content_browsertest_base.{cc,h} 
to 
 content/browser/media/webrtc/
since they are purely internal to content_browsertests.

BUG=627537, 518807
TEST=new content_browsertests 
WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0
 (all platforms)
WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/1
 (android with webcam)
==========

to

==========
ImageCapture: add WebRtcImageCaptureBrowserTest content_browsertest

This CL adds a content_browsertest for ImageCapture:
WebRtcImageCaptureBrowserTest, with one test case,
CreateAndGetCapabilities, that is parameterized to 
exercise the FakeVideoCaptureDevice and, in the very
near future, the system's device if implemented 
(i.e., Android).

WebRtcImageCaptureBrowserTest needs access to the 
physical webcam, but in general content_browsertests
are always using the Fake. WebRtcWebcamBrowserTest has
the necessary infrastructure to do this, so it's made 
public and reused as base class for the former.

Also, this CL moves 
 content/test/webrtc_content_browsertest_base.{cc,h} 
to 
 content/browser/media/webrtc/
since they are purely internal to content_browsertests.

BUG=627537, 518807
TEST=new content_browsertests 
WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0
 (all platforms)
==========

[mcasas, 2016-07-28 23:44:43]

Patchset #3 (id:100001) has been deleted

[mcasas, 2016-07-29 00:00:50]

phoglund@ PTAL

https://codereview.chromium.org/2190523004/diff/60001/content/test/data/media...
File content/test/data/media/image_capture_test.html (right):

https://codereview.chromium.org/2190523004/diff/60001/content/test/data/media...
content/test/data/media/image_capture_test.html:39: // construction in its own
thread. Need to wait yikes!
On 2016/07/28 14:07:49, phoglund_chrome wrote:
> This _will_ be flaky.
> 
> I recommend you write this to retry on err instead. Basically just keep
retrying
> until it succeeds.

Actually, I've have a deeper thought: a user would naturally 
expect to be able to retrieve capabilities right after creating 
the ImageCapture() object (l.34); since getPhotoCapabilities() 
is already Promise-based, the right thing to do is to delay 
resolve()ing the Promise until the said Capabilities are ready 
(which addresses https://crbug.com/627537). I will work on 
closing that bug now and in parallel. 

For the sake of making this review easier and landing this test 
code (that has value in and of itself), I propose continuing the
review while enabling it for FakeVCD only. I'd leave in the 
provisions for using real webcams (i.e. making 
WebRtcImageCaptureBrowserTest derive from 
WebRtcWebCamBrowserTest), and subsequently enabling 
it for platforms where GetCapabilities() is correctly 
implemented (i.e. Android). I'm planning to work on this 
right away, so this CL is also a "preparation" for it.


SG?

For the record, the first idea I had was to listen to the
MediaStream onunmute event, but guess what: it's always
true, including while the camera is producing no frames :)

[phoglund_chromium, 2016-07-29 06:53:31]

Sure. I had no other remarks so lgtm.

[mcasas, 2016-07-29 16:06:16]

mcasas@chromium.org changed reviewers:
+ avi@chromium.org, sergeyu@chromium.org

[mcasas, 2016-07-29 16:06:16]

sergeyu@: content/browser/media/capture/image_capture_impl.cc plz

avi@: RS moving content/test/webrtc_content_browsertest_base.{cc,h}
to a more contained folder please.

[mcasas, 2016-07-29 16:06:26]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 16:06:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-07-29 16:13:16]

lgtm

move stamp

[Sergey Ulanov, 2016-07-29 16:44:00]

lgtm

[mcasas, 2016-07-29 17:17:13]

The CQ bit was unchecked by mcasas@chromium.org

[mcasas, 2016-07-29 17:17:19]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2016-07-29 17:17:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 18:15:20]

Description was changed from

==========
ImageCapture: add WebRtcImageCaptureBrowserTest content_browsertest

This CL adds a content_browsertest for ImageCapture:
WebRtcImageCaptureBrowserTest, with one test case,
CreateAndGetCapabilities, that is parameterized to 
exercise the FakeVideoCaptureDevice and, in the very
near future, the system's device if implemented 
(i.e., Android).

WebRtcImageCaptureBrowserTest needs access to the 
physical webcam, but in general content_browsertests
are always using the Fake. WebRtcWebcamBrowserTest has
the necessary infrastructure to do this, so it's made 
public and reused as base class for the former.

Also, this CL moves 
 content/test/webrtc_content_browsertest_base.{cc,h} 
to 
 content/browser/media/webrtc/
since they are purely internal to content_browsertests.

BUG=627537, 518807
TEST=new content_browsertests 
WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0
 (all platforms)
==========

to

==========
ImageCapture: add WebRtcImageCaptureBrowserTest content_browsertest

This CL adds a content_browsertest for ImageCapture:
WebRtcImageCaptureBrowserTest, with one test case,
CreateAndGetCapabilities, that is parameterized to 
exercise the FakeVideoCaptureDevice and, in the very
near future, the system's device if implemented 
(i.e., Android).

WebRtcImageCaptureBrowserTest needs access to the 
physical webcam, but in general content_browsertests
are always using the Fake. WebRtcWebcamBrowserTest has
the necessary infrastructure to do this, so it's made 
public and reused as base class for the former.

Also, this CL moves 
 content/test/webrtc_content_browsertest_base.{cc,h} 
to 
 content/browser/media/webrtc/
since they are purely internal to content_browsertests.

BUG=627537, 518807
TEST=new content_browsertests 
WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0
 (all platforms)
==========

[commit-bot: I haz the power, 2016-07-29 18:15:23]

Committed patchset #3 (id:120001)

[commit-bot: I haz the power, 2016-07-29 18:16:34]

Description was changed from

==========
ImageCapture: add WebRtcImageCaptureBrowserTest content_browsertest

This CL adds a content_browsertest for ImageCapture:
WebRtcImageCaptureBrowserTest, with one test case,
CreateAndGetCapabilities, that is parameterized to 
exercise the FakeVideoCaptureDevice and, in the very
near future, the system's device if implemented 
(i.e., Android).

WebRtcImageCaptureBrowserTest needs access to the 
physical webcam, but in general content_browsertests
are always using the Fake. WebRtcWebcamBrowserTest has
the necessary infrastructure to do this, so it's made 
public and reused as base class for the former.

Also, this CL moves 
 content/test/webrtc_content_browsertest_base.{cc,h} 
to 
 content/browser/media/webrtc/
since they are purely internal to content_browsertests.

BUG=627537, 518807
TEST=new content_browsertests 
WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0
 (all platforms)
==========

to

==========
ImageCapture: add WebRtcImageCaptureBrowserTest content_browsertest

This CL adds a content_browsertest for ImageCapture:
WebRtcImageCaptureBrowserTest, with one test case,
CreateAndGetCapabilities, that is parameterized to
exercise the FakeVideoCaptureDevice and, in the very
near future, the system's device if implemented
(i.e., Android).

WebRtcImageCaptureBrowserTest needs access to the
physical webcam, but in general content_browsertests
are always using the Fake. WebRtcWebcamBrowserTest has
the necessary infrastructure to do this, so it's made
public and reused as base class for the former.

Also, this CL moves
 content/test/webrtc_content_browsertest_base.{cc,h}
to
 content/browser/media/webrtc/
since they are purely internal to content_browsertests.

BUG=627537, 518807
TEST=new content_browsertests
WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0
 (all platforms)

Committed: https://crrev.com/13c7a2dfcd26e94f607a169de86b937fa21fb236
Cr-Commit-Position: refs/heads/master@{#408690}
==========

[commit-bot: I haz the power, 2016-07-29 18:16:35]

Patchset 3 (id:??) landed as
https://crrev.com/13c7a2dfcd26e94f607a169de86b937fa21fb236
Cr-Commit-Position: refs/heads/master@{#408690}

[Guido Urdaneta, 2016-08-01 10:20:49]

A revert of this CL (patchset #3 id:120001) has been created in
https://codereview.chromium.org/2197143002/ by guidou@chromium.org.

The reason for reverting is: This test is failing very frequently on some WebRTC
Windows Tester bots.

See
https://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/27190

https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win7%20Tester/build...

Sample failure:
[ RUN      ] WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0
[5124:280:0729/121801:1241877:ERROR:singleton_hwnd.cc(34)] Cannot create windows
on non-UI thread!
e:\b\c\b\win_builder\src\content\browser\media\webrtc\webrtc_image_capture_browsertest.cc(77):
error: Failed
[2992:3628:0729/121801:1242001:ERROR:node_controller.cc(1099)] Could not be
introduced to peer 37958025A53036C9.F5421BDB493A3697
[  FAILED  ] WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0, where
GetParam() = 1-byte object <01> (231 ms)
[110/110] WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0 (475 ms)
Retrying 1 test (retry #2)
[ RUN      ] WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0
[2144:1880:0729/121801:1242360:ERROR:singleton_hwnd.cc(34)] Cannot create
windows on non-UI thread!
e:\b\c\b\win_builder\src\content\browser\media\webrtc\webrtc_image_capture_browsertest.cc(77):
error: Failed
[840:5900:0729/121801:1242469:ERROR:node_controller.cc(1099)] Could not be
introduced to peer F1D75502164167AB.19D704C0D84D5C28
[  FAILED  ] WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0, where
GetParam() = 1-byte object <01> (213 ms)
[111/111] WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0 (455 ms)
Retrying 1 test (retry #3)
[ RUN      ] WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0
[5628:5100:0729/121801:1242813:ERROR:singleton_hwnd.cc(34)] Cannot create
windows on non-UI thread!
e:\b\c\b\win_builder\src\content\browser\media\webrtc\webrtc_image_capture_browsertest.cc(77):
error: Failed
[5096:5328:0729/121802:1242937:ERROR:node_controller.cc(1099)] Could not be
introduced to peer 9CA25151C497950C.94F1247A9239863C
[  FAILED  ] WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0, where
GetParam() = 1-byte object <01> (199 ms)
[112/112] WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0 (515 ms)
1 test failed:
    WebRtcImageCaptureBrowserTest.CreateAndGetCapabilities/0
(e:\b\c\b\win_builder\src\content\browser\media\webrtc\webrtc_image_capture_browsertest.cc:67).