Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2190493002:
Extend __mulodi4() hack to 32-bit x86. (Closed)
DescriptionExtend __mulodi4() hack to 32-bit x86.
This gets the Android-Clang-x86 perf bot from failing on __mulodi4() to failing on the next problem...
See https://luci-milo.appspot.com/swarming/task/3042e5f68636f810/steps/nanobench/0/stdout
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190493002
Committed: https://skia.googlesource.com/skia/+/b464764dae4ffa40b880d96cdc368afd890a8a27
Patch Set 1 #Patch Set 2 : woops #Messages
Total messages: 20 (16 generated)
Description was changed from ========== Extend __mulodi4() hack to 32-bit x86. See https://luci-milo.appspot.com/swarming/task/3042e5f68636f810/steps/nanobench/... BUG=skia: ========== to ========== Extend __mulodi4() hack to 32-bit x86. See https://luci-milo.appspot.com/swarming/task/3042e5f68636f810/steps/nanobench/... BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190493002 ==========
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
The CQ bit was checked by mtklein@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by mtklein@google.com
The CQ bit was checked by mtklein@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Extend __mulodi4() hack to 32-bit x86. See https://luci-milo.appspot.com/swarming/task/3042e5f68636f810/steps/nanobench/... BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190493002 ========== to ========== Extend __mulodi4() hack to 32-bit x86. This gets the Android-Clang-x86 perf bot from failing on __mulodi4() to failing on the next problem... See https://luci-milo.appspot.com/swarming/task/3042e5f68636f810/steps/nanobench/... BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190493002 ==========
mtklein@chromium.org changed reviewers: + djsollen@google.com - mtklein@google.com
The CQ bit was checked by mtklein@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
Message was sent while issue was closed.
Description was changed from ========== Extend __mulodi4() hack to 32-bit x86. This gets the Android-Clang-x86 perf bot from failing on __mulodi4() to failing on the next problem... See https://luci-milo.appspot.com/swarming/task/3042e5f68636f810/steps/nanobench/... BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190493002 ========== to ========== Extend __mulodi4() hack to 32-bit x86. This gets the Android-Clang-x86 perf bot from failing on __mulodi4() to failing on the next problem... See https://luci-milo.appspot.com/swarming/task/3042e5f68636f810/steps/nanobench/... BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190493002 Committed: https://skia.googlesource.com/skia/+/b464764dae4ffa40b880d96cdc368afd890a8a27 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/b464764dae4ffa40b880d96cdc368afd890a8a27 |
