Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: gyp/dng_sdk.gyp

Issue 2190493002: Extend __mulodi4() hack to 32-bit x86. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: woops Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 Google Inc. 1 # Copyright 2016 Google Inc.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 # The Adobe DNG SDK, an API for reading and writing DNG files. 5 # The Adobe DNG SDK, an API for reading and writing DNG files.
6 { 6 {
7 'variables': { 7 'variables': {
8 'other_cflags': [ 8 'other_cflags': [
9 '-DqDNGBigEndian=0', 9 '-DqDNGBigEndian=0',
10 '-DqDNGReportErrors=0', 10 '-DqDNGReportErrors=0',
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 '/DqDNGUseXMP#0', 136 '/DqDNGUseXMP#0',
137 '/DqDNGValidate#0', 137 '/DqDNGValidate#0',
138 '/DqDNGValidateTarget#1', 138 '/DqDNGValidateTarget#1',
139 ], 139 ],
140 }, 140 },
141 }, 141 },
142 }], 142 }],
143 ['skia_os != "linux"', { 143 ['skia_os != "linux"', {
144 'sources': ['<@(headers)'], 144 'sources': ['<@(headers)'],
145 }], 145 }],
146 ['skia_arch_type == "arm" and skia_clang_build', { 146 ['(skia_arch_type == "arm" or skia_arch_type == "x86") and skia_clang_build' , {
147 # DNG SDK uses __builtin_smulll_overflow() to detect 64x64 bit multiply ov erflow. 147 # DNG SDK uses __builtin_smulll_overflow() to detect 64x64 bit multiply ov erflow.
148 # On ARMv7, Clang implements this with __mulodi4() in libclang_rt. 148 # On ARMv7 and 32-bit x86, Clang implements this with __mulodi4() in libcl ang_rt.
149 # I can't quite figure out how to link that here, so instead here's a shim for 149 # I can't quite figure out how to link that here, so instead here's a shim for
150 # __builtin_smulll_overflow() that multiplies normally assuming no overflo w. 150 # __builtin_smulll_overflow() that multiplies normally assuming no overflo w.
151 # Tracked in b/29412086. 151 # Tracked in b/29412086.
152 'defines': [ '__builtin_smulll_overflow(x,y,p)=(*(p)=(x)*(y), false)' ], 152 'defines': [ '__builtin_smulll_overflow(x,y,p)=(*(p)=(x)*(y), false)' ],
153 }], 153 }],
154 ], 154 ],
155 'dependencies': [ 155 'dependencies': [
156 'libjpeg-turbo-selector.gyp:libjpeg-turbo-selector', 156 'libjpeg-turbo-selector.gyp:libjpeg-turbo-selector',
157 'zlib.gyp:zlib', 157 'zlib.gyp:zlib',
158 ], 158 ],
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 '../third_party/externals/dng_sdk/source/dng_temperature.cpp', 226 '../third_party/externals/dng_sdk/source/dng_temperature.cpp',
227 '../third_party/externals/dng_sdk/source/dng_tile_iterator.cpp', 227 '../third_party/externals/dng_sdk/source/dng_tile_iterator.cpp',
228 '../third_party/externals/dng_sdk/source/dng_tone_curve.cpp', 228 '../third_party/externals/dng_sdk/source/dng_tone_curve.cpp',
229 '../third_party/externals/dng_sdk/source/dng_utils.cpp', 229 '../third_party/externals/dng_sdk/source/dng_utils.cpp',
230 '../third_party/externals/dng_sdk/source/dng_xy_coord.cpp', 230 '../third_party/externals/dng_sdk/source/dng_xy_coord.cpp',
231 '../third_party/externals/dng_sdk/source/dng_jpeg_memory_source.cpp', 231 '../third_party/externals/dng_sdk/source/dng_jpeg_memory_source.cpp',
232 '../third_party/externals/dng_sdk/source/dng_safe_arithmetic.cpp', 232 '../third_party/externals/dng_sdk/source/dng_safe_arithmetic.cpp',
233 ], 233 ],
234 }], 234 }],
235 } 235 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698