arc: Revamp the ArcBridgeService interface

arc: Revamp the ArcBridgeService interface

Adding a new host/instance pair required a lot of boilerplate. It also
made it very hard to properly do fakes for tests. This change adds two
more interfaces: InterfaceHolder<T> and InterfaceObserver<T>, so that
ArcBridgeService can stop having hundreds of methods to deal with
instance lifecycles.

BUG=626695
TEST=trybots

Review-Url: https://codereview.chromium.org/2133503002
Cr-Commit-Position: refs/heads/master@{#405025}
(cherry picked from commit de2de961f2851a852febfb7223b0f27df5e6afb9)

TBR=afakhry@chromium.org, georgesak@chromium.org, stevenjb@chromium.org, hidehiko@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/f7ef8094f0b07aa9ff481d4af8087ec9a982bd63

[Luis Héctor Chávez, 2016-07-27 18:18:29]

The CQ bit was checked by lhchavez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 18:18:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 18:18:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 18:18:58]

Dry run: CLs for remote refs other than refs/pending/heads/master must contain
NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them

[Luis Héctor Chávez, 2016-07-28 17:37:25]

lgtm, this is a cherry-pick

[Luis Héctor Chávez, 2016-07-28 17:39:31]

Description was changed from

==========
arc: Revamp the ArcBridgeService interface

Adding a new host/instance pair required a lot of boilerplate. It also
made it very hard to properly do fakes for tests. This change adds two
more interfaces: InterfaceHolder<T> and InterfaceObserver<T>, so that
ArcBridgeService can stop having hundreds of methods to deal with
instance lifecycles.

BUG=626695
TEST=trybots

Review-Url: https://codereview.chromium.org/2133503002
Cr-Commit-Position: refs/heads/master@{#405025}
(cherry picked from commit de2de961f2851a852febfb7223b0f27df5e6afb9)
==========

to

==========
arc: Revamp the ArcBridgeService interface

Adding a new host/instance pair required a lot of boilerplate. It also
made it very hard to properly do fakes for tests. This change adds two
more interfaces: InterfaceHolder<T> and InterfaceObserver<T>, so that
ArcBridgeService can stop having hundreds of methods to deal with
instance lifecycles.

BUG=626695
TEST=trybots

Review-Url: https://codereview.chromium.org/2133503002
Cr-Commit-Position: refs/heads/master@{#405025}
(cherry picked from commit de2de961f2851a852febfb7223b0f27df5e6afb9)

NOPRESUBMIT=true
==========

[Luis Héctor Chávez, 2016-07-28 17:39:58]

The CQ bit was checked by lhchavez@chromium.org

[commit-bot: I haz the power, 2016-07-28 17:40:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 17:40:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 17:40:21]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Luis Héctor Chávez, 2016-07-28 17:40:54]

lhchavez@chromium.org changed reviewers:
+ lhchavez@chromium.org

[Luis Héctor Chávez, 2016-07-28 17:40:55]

lgtm

[Luis Héctor Chávez, 2016-07-28 17:59:05]

Description was changed from

==========
arc: Revamp the ArcBridgeService interface

Adding a new host/instance pair required a lot of boilerplate. It also
made it very hard to properly do fakes for tests. This change adds two
more interfaces: InterfaceHolder<T> and InterfaceObserver<T>, so that
ArcBridgeService can stop having hundreds of methods to deal with
instance lifecycles.

BUG=626695
TEST=trybots

Review-Url: https://codereview.chromium.org/2133503002
Cr-Commit-Position: refs/heads/master@{#405025}
(cherry picked from commit de2de961f2851a852febfb7223b0f27df5e6afb9)

NOPRESUBMIT=true
==========

to

==========
arc: Revamp the ArcBridgeService interface

Adding a new host/instance pair required a lot of boilerplate. It also
made it very hard to properly do fakes for tests. This change adds two
more interfaces: InterfaceHolder<T> and InterfaceObserver<T>, so that
ArcBridgeService can stop having hundreds of methods to deal with
instance lifecycles.

BUG=626695
TEST=trybots

Review-Url: https://codereview.chromium.org/2133503002
Cr-Commit-Position: refs/heads/master@{#405025}
(cherry picked from commit de2de961f2851a852febfb7223b0f27df5e6afb9)

TBR=afakhry@chromium.org, georgesak@chromium.org, stevenjb@chromium.org,
hidehiko@chromium.org
==========

[Luis Héctor Chávez, 2016-07-28 18:07:17]

Description was changed from

==========
arc: Revamp the ArcBridgeService interface

Adding a new host/instance pair required a lot of boilerplate. It also
made it very hard to properly do fakes for tests. This change adds two
more interfaces: InterfaceHolder<T> and InterfaceObserver<T>, so that
ArcBridgeService can stop having hundreds of methods to deal with
instance lifecycles.

BUG=626695
TEST=trybots

Review-Url: https://codereview.chromium.org/2133503002
Cr-Commit-Position: refs/heads/master@{#405025}
(cherry picked from commit de2de961f2851a852febfb7223b0f27df5e6afb9)

TBR=afakhry@chromium.org, georgesak@chromium.org, stevenjb@chromium.org,
hidehiko@chromium.org
==========

to

==========
arc: Revamp the ArcBridgeService interface

Adding a new host/instance pair required a lot of boilerplate. It also
made it very hard to properly do fakes for tests. This change adds two
more interfaces: InterfaceHolder<T> and InterfaceObserver<T>, so that
ArcBridgeService can stop having hundreds of methods to deal with
instance lifecycles.

BUG=626695
TEST=trybots

Review-Url: https://codereview.chromium.org/2133503002
Cr-Commit-Position: refs/heads/master@{#405025}
(cherry picked from commit de2de961f2851a852febfb7223b0f27df5e6afb9)

TBR=afakhry@chromium.org, georgesak@chromium.org, stevenjb@chromium.org,
hidehiko@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/f7ef8094f0b07aa9ff481d4af808...
==========

[Luis Héctor Chávez, 2016-07-28 18:07:19]

Committed patchset #4 (id:60001) manually as
f7ef8094f0b07aa9ff481d4af8087ec9a982bd63 (presubmit successful).