arc: Revamp the ArcBridgeService interface

components/arc/ime/arc_ime_bridge_impl.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/arc/ime/arc_ime_bridge_impl.h"
 
 #include "base/logging.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/arc/arc_bridge_service.h"
 #include "ui/base/ime/composition_text.h"
@@ skipping 46 matching lines @@
 
 mojo::Array<arc::mojom::CompositionSegmentPtr> ConvertSegments(
     const ui::CompositionText& composition) {
   mojo::Array<arc::mojom::CompositionSegmentPtr> segments =
       mojo::Array<arc::mojom::CompositionSegmentPtr>::New(0);
   for (const ui::CompositionUnderline& underline : composition.underlines) {
     arc::mojom::CompositionSegmentPtr segment =
         arc::mojom::CompositionSegment::New();
     segment->start_offset = underline.start_offset;
     segment->end_offset = underline.end_offset;
-    segment->emphasized = (underline.thick ||
-        (composition.selection.start() == underline.start_offset &&
-         composition.selection.end() == underline.end_offset));
+    segment->emphasized =
+        (underline.thick ||
+         (composition.selection.start() == underline.start_offset &&
+          composition.selection.end() == underline.end_offset));
     segments.push_back(std::move(segment));
   }
   return segments;
 }
 
 }  // namespace
 
 ArcImeBridgeImpl::ArcImeBridgeImpl(Delegate* delegate,
                                    ArcBridgeService* bridge_service)
     : binding_(this), delegate_(delegate), bridge_service_(bridge_service) {
-  bridge_service_->AddObserver(this);
+  bridge_service_->ime()->AddObserver(this);
 }
 
 ArcImeBridgeImpl::~ArcImeBridgeImpl() {
-  bridge_service_->RemoveObserver(this);
+  bridge_service_->ime()->RemoveObserver(this);
 }
 
-void ArcImeBridgeImpl::OnImeInstanceReady() {
-  bridge_service_->ime_instance()->Init(binding_.CreateInterfacePtrAndBind());
+void ArcImeBridgeImpl::OnInstanceReady() {
+  bridge_service_->ime()->instance()->Init(
+      binding_.CreateInterfacePtrAndBind());
 }
 
 void ArcImeBridgeImpl::SendSetCompositionText(
     const ui::CompositionText& composition) {
-  mojom::ImeInstance* ime_instance = bridge_service_->ime_instance();
+  mojom::ImeInstance* ime_instance = bridge_service_->ime()->instance();
   if (!ime_instance) {
     LOG(ERROR) << "ArcImeInstance method called before being ready.";
     return;
   }
 
   ime_instance->SetCompositionText(base::UTF16ToUTF8(composition.text),
                                    ConvertSegments(composition));
 }
 
 void ArcImeBridgeImpl::SendConfirmCompositionText() {
-  mojom::ImeInstance* ime_instance = bridge_service_->ime_instance();
+  mojom::ImeInstance* ime_instance = bridge_service_->ime()->instance();
   if (!ime_instance) {
     LOG(ERROR) << "ArcImeInstance method called before being ready.";
     return;
   }
 
   ime_instance->ConfirmCompositionText();
 }
 
 void ArcImeBridgeImpl::SendInsertText(const base::string16& text) {
-  mojom::ImeInstance* ime_instance = bridge_service_->ime_instance();
+  mojom::ImeInstance* ime_instance = bridge_service_->ime()->instance();
   if (!ime_instance) {
     LOG(ERROR) << "ArcImeInstance method called before being ready.";
     return;
   }
 
   ime_instance->InsertText(base::UTF16ToUTF8(text));
 }
 
 void ArcImeBridgeImpl::SendOnKeyboardBoundsChanging(
     const gfx::Rect& new_bounds) {
-  mojom::ImeInstance* ime_instance = bridge_service_->ime_instance();
+  mojom::ImeInstance* ime_instance = bridge_service_->ime()->instance();
   if (!ime_instance) {
     LOG(ERROR) << "ArcImeInstance method called before being ready.";
     return;
   }
-  if (bridge_service_->ime_version() <
+  if (bridge_service_->ime()->version() <
       kMinVersionForOnKeyboardsBoundsChanging) {
     LOG(ERROR) << "ArcImeInstance is too old for OnKeyboardsBoundsChanging.";
     return;
   }
 
   ime_instance->OnKeyboardBoundsChanging(new_bounds);
 }
 
 void ArcImeBridgeImpl::SendExtendSelectionAndDelete(
     size_t before, size_t after) {
-  mojom::ImeInstance* ime_instance = bridge_service_->ime_instance();
+  mojom::ImeInstance* ime_instance = bridge_service_->ime()->instance();
   if (!ime_instance) {
     LOG(ERROR) << "ArcImeInstance method called before being ready.";
     return;
   }
-  if (bridge_service_->ime_version() <
+  if (bridge_service_->ime()->version() <
       kMinVersionForExtendSelectionAndDelete) {
     LOG(ERROR) << "ArcImeInstance is too old for ExtendSelectionAndDelete.";
     return;
   }
 
   ime_instance->ExtendSelectionAndDelete(before, after);
 }
 
 void ArcImeBridgeImpl::OnTextInputTypeChanged(arc::mojom::TextInputType type) {
   delegate_->OnTextInputTypeChanged(ConvertTextInputType(type));
 }
 
 void ArcImeBridgeImpl::OnCursorRectChanged(arc::mojom::CursorRectPtr rect) {
-  delegate_->OnCursorRectChanged(gfx::Rect(
-      rect->left,
-      rect->top,
-      rect->right - rect->left,
-      rect->bottom - rect->top));
+  delegate_->OnCursorRectChanged(gfx::Rect(rect->left, rect->top,
+                                           rect->right - rect->left,
+                                           rect->bottom - rect->top));
 }
 
 void ArcImeBridgeImpl::OnCancelComposition() {
   delegate_->OnCancelComposition();
 }
 
 void ArcImeBridgeImpl::ShowImeIfNeeded() {
   delegate_->ShowImeIfNeeded();
 }
 
 }  // namespace arc