Set Error.stack property writable

Set Error.stack property writable

Previously, the stack property was set up in JS as read-only; but since
it had a JS setter, writability was ignored and writing to stack was
possible.

This is no longer the case now that stack is either an actual data
property, or is associated with C++ accessors. Explicitly set the
property as writable to preserve old behavior.

BUG=v8:5245
R=yangguo@chromium.org

Committed: https://crrev.com/1c7c0521f1f9b4e70e19b0999c613fdb3b262deb
Cr-Commit-Position: refs/heads/master@{#38158}

[jgruber, 2016-07-29 07:41:30]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 07:41:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-07-29 07:46:06]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 07:46:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2016-07-29 07:49:53]

On 2016/07/29 07:46:10, commit-bot: I haz the power wrote:
> Dry run: CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

lgtm. thanks.

[commit-bot: I haz the power, 2016-07-29 08:07:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 08:07:41]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-07-29 08:09:53]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2016-07-29 08:09:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 08:11:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-29 08:15:38]

Description was changed from

==========
Set Error.stack property writable

Previously, the stack property was set up in JS as read-only; but since
it had a JS setter, writability was ignored and writing to stack was
possible.

This is no longer the case now that stack is either an actual data
property, or is associated with C++ accessors. Explicitly set the
property as writable to preserve old behavior.

BUG=5245
R=yangguo@chromium.org
==========

to

==========
Set Error.stack property writable

Previously, the stack property was set up in JS as read-only; but since
it had a JS setter, writability was ignored and writing to stack was
possible.

This is no longer the case now that stack is either an actual data
property, or is associated with C++ accessors. Explicitly set the
property as writable to preserve old behavior.

BUG=5245
R=yangguo@chromium.org

Committed: https://crrev.com/1c7c0521f1f9b4e70e19b0999c613fdb3b262deb
Cr-Commit-Position: refs/heads/master@{#38158}
==========

[commit-bot: I haz the power, 2016-07-29 08:15:38]

Patchset 2 (id:??) landed as
https://crrev.com/1c7c0521f1f9b4e70e19b0999c613fdb3b262deb
Cr-Commit-Position: refs/heads/master@{#38158}

[neis, 2016-07-29 08:21:14]

Description was changed from

==========
Set Error.stack property writable

Previously, the stack property was set up in JS as read-only; but since
it had a JS setter, writability was ignored and writing to stack was
possible.

This is no longer the case now that stack is either an actual data
property, or is associated with C++ accessors. Explicitly set the
property as writable to preserve old behavior.

BUG=5245
R=yangguo@chromium.org

Committed: https://crrev.com/1c7c0521f1f9b4e70e19b0999c613fdb3b262deb
Cr-Commit-Position: refs/heads/master@{#38158}
==========

to

==========
Set Error.stack property writable

Previously, the stack property was set up in JS as read-only; but since
it had a JS setter, writability was ignored and writing to stack was
possible.

This is no longer the case now that stack is either an actual data
property, or is associated with C++ accessors. Explicitly set the
property as writable to preserve old behavior.

BUG=v8:5245
R=yangguo@chromium.org

Committed: https://crrev.com/1c7c0521f1f9b4e70e19b0999c613fdb3b262deb
Cr-Commit-Position: refs/heads/master@{#38158}
==========

[stefan.penner, 2016-07-29 17:57:08]

stefan.penner@gmail.com changed reviewers:
+ stefan.penner@gmail.com

[stefan.penner, 2016-07-29 17:57:09]

lgtm