Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2190313002: Set Error.stack property writable (Closed)

Created:
4 years, 4 months ago by jgruber
Modified:
4 years, 4 months ago
Reviewers:
stefan.penner, Yang
CC:
Benedikt Meurer, Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Set Error.stack property writable Previously, the stack property was set up in JS as read-only; but since it had a JS setter, writability was ignored and writing to stack was possible. This is no longer the case now that stack is either an actual data property, or is associated with C++ accessors. Explicitly set the property as writable to preserve old behavior. BUG=v8:5245 R=yangguo@chromium.org Committed: https://crrev.com/1c7c0521f1f9b4e70e19b0999c613fdb3b262deb Cr-Commit-Position: refs/heads/master@{#38158}

Patch Set 1 #

Patch Set 2 : More test cases #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M src/builtins/builtins-error.cc View 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/regress/regress-5245.js View 1 1 chunk +24 lines, -0 lines 0 comments Download
M test/mjsunit/stack-traces.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
Yang
On 2016/07/29 07:46:10, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 4 months ago (2016-07-29 07:49:53 UTC) #5
jgruber
4 years, 4 months ago (2016-07-29 07:56:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190313002/20001
4 years, 4 months ago (2016-07-29 08:09:59 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-29 08:11:43 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/1c7c0521f1f9b4e70e19b0999c613fdb3b262deb Cr-Commit-Position: refs/heads/master@{#38158}
4 years, 4 months ago (2016-07-29 08:15:38 UTC) #13
stefan.penner
4 years, 4 months ago (2016-07-29 17:57:09 UTC) #16
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698