src/builtins/builtins-error.cc - Issue 2190313002: Set Error.stack property writable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins/builtins-error.cc

Issue 2190313002: Set Error.stack property writable (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: More test cases Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins/builtins-error.cc

diff --git a/src/builtins/builtins-error.cc b/src/builtins/builtins-error.cc

index ae294f7f85c5c40be37530a0d52a615672614566..3176f13f21307db5b6c499893aa3e468d3922d3e 100644

--- a/src/builtins/builtins-error.cc

+++ b/src/builtins/builtins-error.cc

@@ -53,6 +53,7 @@ BUILTIN(ErrorCaptureStackTrace) {

PropertyDescriptor desc;

desc.set_configurable(true);

+ desc.set_writable(true);

desc.set_value(formatted_stack_trace);

Maybe<bool> status = JSReceiver::DefineOwnProperty(

isolate, object, isolate->factory()->stack_string(), &desc,

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-5245.js » ('j') | no next file with comments »