Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2190243002: [MD settings] update site details permission layout (Closed)

Created:
4 years, 4 months ago by dschuyler
Modified:
4 years, 4 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] update site details permission layout This CL updates the permission dropdown menu so that it matches the mocks better. BUG=632535 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/e54a2f9cfe2cd2ec5cb5ab32ddd2071a061b3aeb Cr-Commit-Position: refs/heads/master@{#408841}

Patch Set 1 #

Patch Set 2 : unit test fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -69 lines) Patch
M chrome/browser/resources/settings/site_settings/site_details_permission.html View 1 2 chunks +21 lines, -57 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_details_permission.js View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_settings_behavior.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/webui/settings/site_details_permission_tests.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (13 generated)
dschuyler
4 years, 4 months ago (2016-07-29 01:06:40 UTC) #5
dschuyler
On 2016/07/29 01:06:40, dschuyler wrote: I intend to upload screen shots once I'm able to ...
4 years, 4 months ago (2016-07-29 01:07:20 UTC) #6
dschuyler
screen shots at: http://imgur.com/a/QlUog
4 years, 4 months ago (2016-07-29 01:08:23 UTC) #7
dschuyler
screen shots at: http://imgur.com/a/QlUog
4 years, 4 months ago (2016-07-29 01:08:25 UTC) #8
dschuyler
screen shots at: http://imgur.com/a/QlUog
4 years, 4 months ago (2016-07-29 01:08:27 UTC) #9
stevenjb
Nice. lgtm.
4 years, 4 months ago (2016-07-29 16:23:31 UTC) #12
dschuyler
I made small changes to fix a unit test.
4 years, 4 months ago (2016-07-30 00:43:35 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190243002/20001
4 years, 4 months ago (2016-07-30 02:08:10 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-30 02:11:18 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-07-30 02:13:08 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e54a2f9cfe2cd2ec5cb5ab32ddd2071a061b3aeb
Cr-Commit-Position: refs/heads/master@{#408841}

Powered by Google App Engine
This is Rietveld 408576698