Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2713)

Unified Diff: chrome/browser/resources/settings/site_settings/site_details_permission.html

Issue 2190243002: [MD settings] update site details permission layout (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: unit test fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/site_settings/site_details_permission.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/site_settings/site_details_permission.html
diff --git a/chrome/browser/resources/settings/site_settings/site_details_permission.html b/chrome/browser/resources/settings/site_settings/site_details_permission.html
index 0a81d68aa3454bd479db9e45dad1e0d4b215965f..58fa36d7b467bd780d91dc7bd3a19497ad11bf6b 100644
--- a/chrome/browser/resources/settings/site_settings/site_details_permission.html
+++ b/chrome/browser/resources/settings/site_settings/site_details_permission.html
@@ -1,10 +1,8 @@
<link rel="import" href="chrome://resources/html/polymer.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-flex-layout.html">
<link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-dropdown-menu/paper-dropdown-menu.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-listbox/paper-listbox.html">
<link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">
-<link rel="import" href="/i18n_setup.html">
<link rel="import" href="/settings_shared_css.html">
<link rel="import" href="/site_settings/constants.html">
<link rel="import" href="/site_settings/site_settings_behavior.html">
@@ -13,64 +11,30 @@
<dom-module id="site-details-permission">
<template>
<style include="settings-shared">
- :host {
- display: block;
- }
-
- .left-column {
- -webkit-margin-start: 15px;
- }
-
- .right-column {
- -webkit-margin-start: 10px;
- }
-
- .permission-header {
- -webkit-margin-start: -1px;
- }
-
- .permission-list {
- -webkit-margin-end: 7px;
- }
-
- .permission-list > paper-dropdown-menu {
- -webkit-margin-end: 3px;
- -webkit-margin-start: -13px;
- margin-bottom: 12px;
- margin-top: -20px;
- width: 100%;
- }
-
- .permission-list > paper-dropdown-menu::shadow > paper-menu-button {
- -webkit-margin-start: 11px;
- width: 100%;
- }
</style>
- <div id="details" class="horizontal layout top" hidden>
- <div class="left-column">
- <iron-icon icon="[[computeIconForContentCategory(category)]]">
- </iron-icon>
- </div>
- <div class="flex right-column">
- <div class="permission-header">
- [[computeTitleForContentCategory(category)]]
+ <div id="details" class="list-frame" hidden>
+ <div class="list-item underbar">
+ <div>
+ <iron-icon icon="[[computeIconForContentCategory(category)]]">
+ </iron-icon>
</div>
- <div class="permission-list">
- <paper-dropdown-menu vertical-align="auto">
- <paper-listbox id="permission" class="dropdown-content"
- on-iron-activate="onPermissionMenuIronActivate_"
- attr-for-selected="data-permission-value">
- <button id="allow" class="dropdown-item" role="option"
- data-permission-value$="[[PermissionValues.ALLOW]]">
- [[i18n_.allowAction]]
- </button>
- <button id="block" class="dropdown-item" role="option"
- data-permission-value$="[[PermissionValues.BLOCK]]">
- [[i18n_.blockAction]]
- </button>
- </paper-listbox>
- </paper-dropdown-menu>
+ <div class="middle" id="permissionHeader">
+ [[computeTitleForContentCategory(category)]]
</div>
+ <paper-dropdown-menu vertical-align="auto" no-label-float>
+ <paper-listbox id="permission" class="dropdown-content"
+ on-iron-activate="onPermissionMenuIronActivate_"
+ attr-for-selected="data-permission-value">
+ <button id="allow" class="dropdown-item" role="option"
+ data-permission-value$="[[PermissionValues.ALLOW]]">
+ $i18n{siteSettingsActionAllow}
+ </button>
+ <button id="block" class="dropdown-item" role="option"
+ data-permission-value$="[[PermissionValues.BLOCK]]">
+ $i18n{siteSettingsActionBlock}
+ </button>
+ </paper-listbox>
+ </paper-dropdown-menu>
</div>
</div>
</template>
« no previous file with comments | « no previous file | chrome/browser/resources/settings/site_settings/site_details_permission.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698