Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 219023011: Fold SkTSetBit into SkOTSet*Bit. (Closed)

Created:
6 years, 8 months ago by mtklein_C
Modified:
6 years, 8 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fold SkTSetBit into SkOTSet*Bit. BUG=b/13729420 Committed: http://code.google.com/p/skia/source/detail?r=14009

Patch Set 1 #

Patch Set 2 : add back asserts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -13 lines) Patch
M include/core/SkTemplates.h View 2 chunks +0 lines, -10 lines 0 comments Download
M src/sfnt/SkOTTableTypes.h View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
mtklein
6 years, 8 months ago (2014-03-31 22:36:00 UTC) #1
bungeman-skia
*sigh* this looks terrible to me, but since we can't use basic c++... whatevs. lgtm
6 years, 8 months ago (2014-04-01 14:29:10 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 8 months ago (2014-04-01 14:30:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/219023011/20001
6 years, 8 months ago (2014-04-01 14:30:49 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 14:30:55 UTC) #5
commit-bot: I haz the power
Presubmit check for 219023011-20001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 8 months ago (2014-04-01 14:30:55 UTC) #6
mtklein
First public API approval wins...
6 years, 8 months ago (2014-04-01 14:33:11 UTC) #7
bsalomon
lgtm. What do I win?
6 years, 8 months ago (2014-04-01 14:40:01 UTC) #8
mtklein
On 2014/04/01 14:40:01, bsalomon wrote: > lgtm. What do I win? FREE LUNCH!
6 years, 8 months ago (2014-04-01 14:41:01 UTC) #9
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 8 months ago (2014-04-01 14:41:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/219023011/20001
6 years, 8 months ago (2014-04-01 14:41:09 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 16:11:59 UTC) #12
Message was sent while issue was closed.
Change committed as 14009

Powered by Google App Engine
This is Rietveld 408576698