Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/sfnt/SkOTTableTypes.h

Issue 219023011: Fold SkTSetBit into SkOTSet*Bit. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: add back asserts Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « include/core/SkTemplates.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 Google Inc. 2 * Copyright 2012 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef SkOTTableTypes_DEFINED 8 #ifndef SkOTTableTypes_DEFINED
9 #define SkOTTableTypes_DEFINED 9 #define SkOTTableTypes_DEFINED
10 10
(...skipping 30 matching lines...) Expand all
41 * SkOTTableTAG<T>::value is the big endian value of an OpenType table tag. 41 * SkOTTableTAG<T>::value is the big endian value of an OpenType table tag.
42 * It may be directly compared with raw big endian table data. 42 * It may be directly compared with raw big endian table data.
43 */ 43 */
44 static const SK_OT_ULONG value = SkTEndian_SwapBE32( 44 static const SK_OT_ULONG value = SkTEndian_SwapBE32(
45 SkSetFourByteTag(T::TAG0, T::TAG1, T::TAG2, T::TAG3) 45 SkSetFourByteTag(T::TAG0, T::TAG1, T::TAG2, T::TAG3)
46 ); 46 );
47 }; 47 };
48 48
49 /** SkOTSetUSHORTBit<N>::value is an SK_OT_USHORT with the Nth BE bit set. */ 49 /** SkOTSetUSHORTBit<N>::value is an SK_OT_USHORT with the Nth BE bit set. */
50 template <unsigned N> struct SkOTSetUSHORTBit { 50 template <unsigned N> struct SkOTSetUSHORTBit {
51 static const uint16_t bit = SkTSetBit<N, uint16_t>::value; 51 SK_COMPILE_ASSERT(N < 16, NTooBig);
52 static const uint16_t bit = 1u << N;
52 static const SK_OT_USHORT value = SkTEndian_SwapBE16(bit); 53 static const SK_OT_USHORT value = SkTEndian_SwapBE16(bit);
53 }; 54 };
54 55
55 /** SkOTSetUSHORTBit<N>::value is an SK_OT_ULONG with the Nth BE bit set. */ 56 /** SkOTSetULONGBit<N>::value is an SK_OT_ULONG with the Nth BE bit set. */
56 template <unsigned N> struct SkOTSetULONGBit { 57 template <unsigned N> struct SkOTSetULONGBit {
57 static const uint32_t bit = SkTSetBit<N, uint32_t>::value; 58 SK_COMPILE_ASSERT(N < 32, NTooBig);
59 static const uint32_t bit = 1u << N;
58 static const SK_OT_ULONG value = SkTEndian_SwapBE32(bit); 60 static const SK_OT_ULONG value = SkTEndian_SwapBE32(bit);
59 }; 61 };
60 62
61 #endif 63 #endif
OLDNEW
« no previous file with comments | « include/core/SkTemplates.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698