Chromium Code Reviews| Index: media/audio/audio_input_controller.cc |
| diff --git a/media/audio/audio_input_controller.cc b/media/audio/audio_input_controller.cc |
| index ef2c4a9e2e871178e21eb08be2b704136bbcfac1..fe6e19d16b9b5d1373206eaa108cca73d6431c27 100644 |
| --- a/media/audio/audio_input_controller.cc |
| +++ b/media/audio/audio_input_controller.cc |
| @@ -202,11 +202,14 @@ void AudioInputController::DoCreateForStream( |
| DCHECK(!no_data_timer_.get()); |
| -#if defined(OS_MACOSX) |
| // This is a fix for crbug.com/357501. The timer can trigger when closing |
| // the lid on Macs, which causes more problems than the timer fixes. |
| + // Also, in crbug.com/357569, the goal is to remove usage of this timer |
| + // since it was added to solve a crach on Windowsw that no longer can be |
|
tommi (sloooow) - chröme
2014/03/31 11:11:52
nit: s/crach/crash s/Windowsw/Windows s/that no lo
henrika (OOO until Aug 14)
2014/03/31 11:21:53
Done.
|
| + // reproduced. |
| + // TODO(henrika): verify that setting |enable_nodata_timer| to false on all |
| + // platforms is a valid change. |
|
tommi (sloooow) - chröme
2014/03/31 11:11:52
is this something you intend to do before actually
henrika (OOO until Aug 14)
2014/03/31 11:21:53
Thanks. Will rewrite the TODO. Plan was to use Can
|
| enable_nodata_timer = false; |
| -#endif |
| if (enable_nodata_timer) { |
| // Create the data timer which will call DoCheckForNoData(). The timer |