Disables the check for no data timer for audio on all platforms

media/audio/audio_input_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/audio/audio_input_controller.h"
 
 #include "base/bind.h"
 #include "base/threading/thread_restrictions.h"
 #include "media/base/limits.h"
 #include "media/base/scoped_histogram_timer.h"
@@ skipping 184 matching lines @@
 
   if (stream_ && !stream_->Open()) {
     stream_->Close();
     stream_ = NULL;
     handler_->OnError(this, STREAM_OPEN_ERROR);
     return;
   }
 
   DCHECK(!no_data_timer_.get());
 
-#if defined(OS_MACOSX)
   // This is a fix for crbug.com/357501.  The timer can trigger when closing
   // the lid on Macs, which causes more problems than the timer fixes.
+  // Also, in crbug.com/357569, the goal is to remove usage of this timer
+  // since it was added to solve a crach on Windowsw that no longer can be

[tommi (sloooow) - chröme, 2014/03/31 11:11:52]

nit: s/crach/crash s/Windowsw/Windows s/that no longer can be/that can no longer
be

[henrika (OOO until Aug 14), 2014/03/31 11:21:53]

Done.

+  // reproduced.
+  // TODO(henrika): verify that setting |enable_nodata_timer| to false on all
+  // platforms is a valid change.

[tommi (sloooow) - chröme, 2014/03/31 11:11:52]

is this something you intend to do before actually making the change (as in
landing)?
If we're going to use canary and M36 for testing this, then I think we don't
need to add this todo.
You could however add a TODO to remove this parameter altogether as well as
everything relating to no_data_timer_.

[henrika (OOO until Aug 14), 2014/03/31 11:21:53]

Thanks. Will rewrite the TODO. Plan was to use Canary as you say.

   enable_nodata_timer = false;
-#endif
 
   if (enable_nodata_timer) {
     // Create the data timer which will call DoCheckForNoData(). The timer
     // is started in DoRecord() and restarted in each DoCheckForNoData()
     // callback.
     no_data_timer_.reset(new base::Timer(
         FROM_HERE, base::TimeDelta::FromSeconds(kTimerInitialIntervalSeconds),
         base::Bind(&AudioInputController::DoCheckForNoData,
                    base::Unretained(this)), false));
   } else {
@@ skipping 173 matching lines @@
 
 void AudioInputController::SetDataIsActive(bool enabled) {
   base::subtle::Release_Store(&data_is_active_, enabled);
 }
 
 bool AudioInputController::GetDataIsActive() {
   return (base::subtle::Acquire_Load(&data_is_active_) != false);
 }
 
 }  // namespace media