Disables the check for no data timer for audio on all platforms

Disables the check for no data timer for audio on all platforms.

BUG=357569
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260570

[henrika (OOO until Aug 14), 2014-03-31 10:37:13]

tommi@: the timer is now disabled on all platforms using a "minimal change fix".

[tommi (sloooow) - chröme, 2014-03-31 11:11:51]

lgtm % nits

https://codereview.chromium.org/219023003/diff/1/media/audio/audio_input_cont...
File media/audio/audio_input_controller.cc (right):

https://codereview.chromium.org/219023003/diff/1/media/audio/audio_input_cont...
media/audio/audio_input_controller.cc:208: // since it was added to solve a
crach on Windowsw that no longer can be
nit: s/crach/crash s/Windowsw/Windows s/that no longer can be/that can no longer
be

https://codereview.chromium.org/219023003/diff/1/media/audio/audio_input_cont...
media/audio/audio_input_controller.cc:211: // platforms is a valid change.
is this something you intend to do before actually making the change (as in
landing)?
If we're going to use canary and M36 for testing this, then I think we don't
need to add this todo.
You could however add a TODO to remove this parameter altogether as well as
everything relating to no_data_timer_.

https://codereview.chromium.org/219023003/diff/1/media/audio/audio_input_cont...
File media/audio/audio_input_controller_unittest.cc (right):

https://codereview.chromium.org/219023003/diff/1/media/audio/audio_input_cont...
media/audio/audio_input_controller_unittest.cc:148: // Disabled due to
crbug.com/357569
and crbug.com/357501?

[henrika (OOO until Aug 14), 2014-03-31 11:21:53]

Thanks. Improved the comments.

https://codereview.chromium.org/219023003/diff/1/media/audio/audio_input_cont...
File media/audio/audio_input_controller.cc (right):

https://codereview.chromium.org/219023003/diff/1/media/audio/audio_input_cont...
media/audio/audio_input_controller.cc:208: // since it was added to solve a
crach on Windowsw that no longer can be
On 2014/03/31 11:11:52, tommi wrote:
> nit: s/crach/crash s/Windowsw/Windows s/that no longer can be/that can no
longer
> be

Done.

https://codereview.chromium.org/219023003/diff/1/media/audio/audio_input_cont...
media/audio/audio_input_controller.cc:211: // platforms is a valid change.
Thanks. Will rewrite the TODO. Plan was to use Canary as you say.

[tommi (sloooow) - chröme, 2014-03-31 11:27:09]

lgtm

[henrika (OOO until Aug 14), 2014-03-31 11:35:15]

Was not able to provoke any crashes using WebSpeech demos.

[henrika (OOO until Aug 14), 2014-03-31 11:43:08]

The CQ bit was checked by henrika@chromium.org

[commit-bot: I haz the power, 2014-03-31 11:43:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/henrika@chromium.org/219023003/20001

[commit-bot: I haz the power, 2014-03-31 12:58:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-31 12:58:27]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[henrika (OOO until Aug 14), 2014-03-31 14:35:07]

The CQ bit was checked by henrika@chromium.org

[commit-bot: I haz the power, 2014-03-31 14:35:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/henrika@chromium.org/219023003/20001

[henrika (OOO until Aug 14), 2014-03-31 14:37:22]

The CQ bit was unchecked by henrika@chromium.org

[henrika (OOO until Aug 14), 2014-03-31 16:46:59]

The CQ bit was checked by henrika@chromium.org

[commit-bot: I haz the power, 2014-03-31 16:47:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/henrika@chromium.org/219023003/20001

[commit-bot: I haz the power, 2014-03-31 16:49:01]

Change committed as 260570