Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2190073002: Revert of Revert "Allow SequencedTaskRunnerHandle::Get() while running unsequenced tasks." (Closed)

Created:
4 years, 4 months ago by gab
Modified:
4 years, 4 months ago
Reviewers:
danakj
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert "Allow SequencedTaskRunnerHandle::Get() while running unsequenced tasks." (patchset #2 id:40001 of https://codereview.chromium.org/2177373005/ ) Reason for revert: Actually oops forgot this wasn't supposed to land until this blocker is resolved : https://bugs.chromium.org/p/chromium/issues/detail?id=618043#c5 Original issue's description: > Revert "Allow SequencedTaskRunnerHandle::Get() while running unsequenced tasks." > > This is effectively a manual revert of 5d315e4b4a7cdef34b0c1e863353d03a30781217. > > Per the outcome of the discussion on http://crbug.com/618043 and associated doc/chromium-dev discussion. > > BUG=618043 > > Committed: https://crrev.com/41339c7ae8458dd500d1be0e9d4b8da6d8c4c33b > Cr-Commit-Position: refs/heads/master@{#408440} TBR=danakj@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=618043 Committed: https://crrev.com/33a2c419dbc05f970bc5de86ad7f3d3919a93bc2 Cr-Commit-Position: refs/heads/master@{#408448}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -70 lines) Patch
M base/threading/sequenced_task_runner_handle.h View 1 chunk +2 lines, -3 lines 0 comments Download
M base/threading/sequenced_task_runner_handle.cc View 2 chunks +8 lines, -12 lines 0 comments Download
M base/threading/sequenced_task_runner_handle_unittest.cc View 4 chunks +3 lines, -12 lines 0 comments Download
M base/threading/sequenced_worker_pool.h View 3 chunks +19 lines, -5 lines 0 comments Download
M base/threading/sequenced_worker_pool.cc View 5 chunks +64 lines, -0 lines 0 comments Download
M base/threading/sequenced_worker_pool_unittest.cc View 2 chunks +133 lines, -38 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
gab
Created Revert of Revert "Allow SequencedTaskRunnerHandle::Get() while running unsequenced tasks."
4 years, 4 months ago (2016-07-28 19:04:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2190073002/1
4 years, 4 months ago (2016-07-28 19:04:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 19:05:51 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 19:09:58 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33a2c419dbc05f970bc5de86ad7f3d3919a93bc2
Cr-Commit-Position: refs/heads/master@{#408448}

Powered by Google App Engine
This is Rietveld 408576698