Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: base/threading/sequenced_task_runner_handle.h

Issue 2190073002: Revert of Revert "Allow SequencedTaskRunnerHandle::Get() while running unsequenced tasks." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/threading/sequenced_task_runner_handle.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_THREADING_SEQUENCED_TASK_RUNNER_HANDLE_H_ 5 #ifndef BASE_THREADING_SEQUENCED_TASK_RUNNER_HANDLE_H_
6 #define BASE_THREADING_SEQUENCED_TASK_RUNNER_HANDLE_H_ 6 #define BASE_THREADING_SEQUENCED_TASK_RUNNER_HANDLE_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
11 #include "base/sequenced_task_runner.h" 11 #include "base/sequenced_task_runner.h"
12 12
13 namespace base { 13 namespace base {
14 14
15 class BASE_EXPORT SequencedTaskRunnerHandle { 15 class BASE_EXPORT SequencedTaskRunnerHandle {
16 public: 16 public:
17 // Returns a SequencedTaskRunner which guarantees that posted tasks will only 17 // Returns a SequencedTaskRunner which guarantees that posted tasks will only
18 // run after the current task is finished and will satisfy a SequenceChecker. 18 // run after the current task is finished and will satisfy a SequenceChecker.
19 // It should only be called if IsSet() returns true (see the comment there for 19 // It should only be called if IsSet() returns true (see the comment there for
20 // the requirements). 20 // the requirements).
21 static scoped_refptr<SequencedTaskRunner> Get(); 21 static scoped_refptr<SequencedTaskRunner> Get();
22 22
23 // Returns true if one of the following conditions is fulfilled: 23 // Returns true if one of the following conditions is fulfilled:
24 // a) A SequencedTaskRunner has been assigned to the current thread by 24 // a) A SequencedTaskRunner has been assigned to the current thread by
25 // instantiating a SequencedTaskRunnerHandle. 25 // instantiating a SequencedTaskRunnerHandle.
26 // b) The current thread has a ThreadTaskRunnerHandle (which includes any 26 // b) The current thread has a ThreadTaskRunnerHandle (which includes any
27 // thread that has a MessageLoop associated with it), or 27 // thread that has a MessageLoop associated with it), or
28 // c) The current thread is a worker thread belonging to a SequencedWorkerPool 28 // c) The current thread is a worker thread belonging to a
29 // *and* is currently running a sequenced task (note: not supporting 29 // SequencedWorkerPool.
30 // unsequenced tasks is intentional: https://crbug.com/618043#c4).
31 static bool IsSet(); 30 static bool IsSet();
32 31
33 // Binds |task_runner| to the current thread. 32 // Binds |task_runner| to the current thread.
34 explicit SequencedTaskRunnerHandle( 33 explicit SequencedTaskRunnerHandle(
35 scoped_refptr<SequencedTaskRunner> task_runner); 34 scoped_refptr<SequencedTaskRunner> task_runner);
36 ~SequencedTaskRunnerHandle(); 35 ~SequencedTaskRunnerHandle();
37 36
38 private: 37 private:
39 scoped_refptr<SequencedTaskRunner> task_runner_; 38 scoped_refptr<SequencedTaskRunner> task_runner_;
40 39
41 DISALLOW_COPY_AND_ASSIGN(SequencedTaskRunnerHandle); 40 DISALLOW_COPY_AND_ASSIGN(SequencedTaskRunnerHandle);
42 }; 41 };
43 42
44 } // namespace base 43 } // namespace base
45 44
46 #endif // BASE_THREADING_SEQUENCED_TASK_RUNNER_HANDLE_H_ 45 #endif // BASE_THREADING_SEQUENCED_TASK_RUNNER_HANDLE_H_
OLDNEW
« no previous file with comments | « no previous file | base/threading/sequenced_task_runner_handle.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698