Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2190063002: cc: Remove DCHECK for invalid image (Closed)

Created:
4 years, 4 months ago by enne (OOO)
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

cc: Remove DCHECK for invalid image This appears to happen sometimes due to render process shutdown racing with drawing a frame using software resources from that renderer. Previously this wouldn't DCHECK at all and would just early out. BUG=626203, chromedriver:1418 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2132723002 Cr-Commit-Position: refs/heads/master@{#404251} (cherry picked from commit 011f68cd2fa0d9fff7fd9808043d6a7fae6e478c) Committed: https://chromium.googlesource.com/chromium/src/+/26d84ddd5e900ab6f508b2fbf72a1caa9b1f8a51

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M cc/resources/resource_provider.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
enne (OOO)
4 years, 4 months ago (2016-07-28 19:08:03 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
26d84ddd5e900ab6f508b2fbf72a1caa9b1f8a51.

Powered by Google App Engine
This is Rietveld 408576698