Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2132723002: cc: Remove DCHECK for invalid image (Closed)

Created:
4 years, 5 months ago by enne (OOO)
Modified:
4 years, 5 months ago
Reviewers:
ericrk
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove DCHECK for invalid image This appears to happen sometimes due to render process shutdown racing with drawing a frame using software resources from that renderer. Previously this wouldn't DCHECK at all and would just early out. BUG=626203, chromedriver:1418 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/011f68cd2fa0d9fff7fd9808043d6a7fae6e478c Cr-Commit-Position: refs/heads/master@{#404251}

Patch Set 1 #

Patch Set 2 : Don't DCHECK at all to preserve old behavior #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M cc/resources/resource_provider.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
enne (OOO)
4 years, 5 months ago (2016-07-07 18:33:02 UTC) #3
ericrk
lgtm
4 years, 5 months ago (2016-07-07 18:52:39 UTC) #4
ericrk
lgtm again :D
4 years, 5 months ago (2016-07-07 19:03:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2132723002/20001
4 years, 5 months ago (2016-07-07 19:04:46 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-07 22:16:31 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 22:16:35 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 22:19:30 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/011f68cd2fa0d9fff7fd9808043d6a7fae6e478c
Cr-Commit-Position: refs/heads/master@{#404251}

Powered by Google App Engine
This is Rietveld 408576698