Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2189973003: Fuchsia: Make some more VM tests pass (Closed)

Created:
4 years, 4 months ago by zra
Modified:
4 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -46 lines) Patch
M runtime/bin/run_vm_tests_fuchsia.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M runtime/platform/utils_fuchsia.h View 2 chunks +7 lines, -13 lines 0 comments Download
M runtime/vm/os_fuchsia.cc View 3 chunks +15 lines, -7 lines 0 comments Download
M runtime/vm/os_thread_fuchsia.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M runtime/vm/virtual_memory_fuchsia.cc View 1 chunk +0 lines, -1 line 2 comments Download

Messages

Total messages: 6 (2 generated)
zra
4 years, 4 months ago (2016-07-28 21:39:18 UTC) #2
siva
lgtm https://codereview.chromium.org/2189973003/diff/1/runtime/vm/virtual_memory_fuchsia.cc File runtime/vm/virtual_memory_fuchsia.cc (right): https://codereview.chromium.org/2189973003/diff/1/runtime/vm/virtual_memory_fuchsia.cc#newcode70 runtime/vm/virtual_memory_fuchsia.cc:70: bool VirtualMemory::FreeSubSegment(void* address, intptr_t size) { Will this ...
4 years, 4 months ago (2016-07-29 00:34:54 UTC) #3
zra
Committed patchset #1 (id:1) manually as 74bbc7f55f963c05bb3f7f13a42771d1b8e781de (presubmit successful).
4 years, 4 months ago (2016-07-29 15:07:29 UTC) #5
zra
4 years, 4 months ago (2016-07-29 15:07:39 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2189973003/diff/1/runtime/vm/virtual_memory_f...
File runtime/vm/virtual_memory_fuchsia.cc (right):

https://codereview.chromium.org/2189973003/diff/1/runtime/vm/virtual_memory_f...
runtime/vm/virtual_memory_fuchsia.cc:70: bool
VirtualMemory::FreeSubSegment(void* address, intptr_t size) {
On 2016/07/29 00:34:54, siva wrote:
> Will this be a nop even after Issue MG-133 is fixed?

This needs issue MG-162 as with the destructor. I've added a TODO.

Powered by Google App Engine
This is Rietveld 408576698