runtime/vm/virtual_memory_fuchsia.cc - Issue 2189973003: Fuchsia: Make some more VM tests pass

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/virtual_memory_fuchsia.cc

Issue 2189973003: Fuchsia: Make some more VM tests pass (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/virtual_memory_fuchsia.cc

diff --git a/runtime/vm/virtual_memory_fuchsia.cc b/runtime/vm/virtual_memory_fuchsia.cc

index 933f494ad0eacfde1013350ba3eac5ea49a9d93a..26aacc23e731dc365df07fa8e1dba33b08c32839 100644

--- a/runtime/vm/virtual_memory_fuchsia.cc

+++ b/runtime/vm/virtual_memory_fuchsia.cc

@@ -68,7 +68,6 @@ VirtualMemory::~VirtualMemory() {

bool VirtualMemory::FreeSubSegment(void* address, intptr_t size) {

siva 2016/07/29 00:34:54 Will this be a nop even after Issue MG-133 is fixe

zra 2016/07/29 15:07:38 This needs issue MG-162 as with the destructor. I'

- UNIMPLEMENTED();

return false;

}

« no previous file with comments | « runtime/vm/os_thread_fuchsia.cc ('k') | no next file » | no next file with comments »