Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 218993017: Delete chicken/egg compositing geometry updates (Closed)

Created:
6 years, 8 months ago by abarth-chromium
Modified:
6 years, 8 months ago
Reviewers:
esprehn
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, jchaffraix+rendering, pdr., rune+blink, chrishtr, ojan, Ian Vollick
Visibility:
Public.

Description

Delete chicken/egg compositing geometry updates After this CL, we don't update the graphics layer geometry incrementally. Instead, the updates are deferred until its actually time to do a compositing update. There's a lot of cleanup we can do after this CL lands, but I wanted to keep this CL small. We can do the cleanup in subsequent CLs. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170630

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -58 lines) Patch
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 1 chunk +0 lines, -21 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 2 chunks +1 line, -34 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
abarth-chromium
This CL depends on https://codereview.chromium.org/220163006/ which should land momentarily.
6 years, 8 months ago (2014-04-01 20:35:36 UTC) #1
esprehn
lgtm
6 years, 8 months ago (2014-04-01 20:43:44 UTC) #2
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 8 months ago (2014-04-01 23:57:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/218993017/1
6 years, 8 months ago (2014-04-01 23:57:36 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 00:57:07 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-02 00:57:07 UTC) #6
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 8 months ago (2014-04-02 01:03:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/218993017/1
6 years, 8 months ago (2014-04-02 01:03:34 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 01:49:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-02 01:49:48 UTC) #10
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 8 months ago (2014-04-02 02:15:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/218993017/1
6 years, 8 months ago (2014-04-02 02:16:00 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 03:22:08 UTC) #13
Message was sent while issue was closed.
Change committed as 170630

Powered by Google App Engine
This is Rietveld 408576698