Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 218993012: DevTools: [JsDocValidator] Handle types declared as top-level vars (Closed)

Created:
6 years, 8 months ago by apavlov
Modified:
6 years, 8 months ago
Reviewers:
sergeyv, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: [JsDocValidator] Handle types declared as top-level vars This patch allows the validator checks to handle types declared as /** @constructor */ var MyType = function() {} R=pfeldman, sergeyv Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170555

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move case to keep the order consistent between methods #

Messages

Total messages: 9 (0 generated)
apavlov
6 years, 8 months ago (2014-04-01 10:21:35 UTC) #1
sergeyv
lgtm with nits https://codereview.chromium.org/218993012/diff/1/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/AstUtil.java File Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/AstUtil.java (right): https://codereview.chromium.org/218993012/diff/1/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/AstUtil.java#newcode83 Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/AstUtil.java:83: switch (parentNode.getType()) { code duplication we ...
6 years, 8 months ago (2014-04-01 11:30:45 UTC) #2
apavlov
https://codereview.chromium.org/218993012/diff/1/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/AstUtil.java File Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/AstUtil.java (right): https://codereview.chromium.org/218993012/diff/1/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/AstUtil.java#newcode83 Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/AstUtil.java:83: switch (parentNode.getType()) { On 2014/04/01 11:30:45, sergeyv wrote: > ...
6 years, 8 months ago (2014-04-01 11:37:28 UTC) #3
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 8 months ago (2014-04-01 11:39:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/218993012/20001
6 years, 8 months ago (2014-04-01 11:39:32 UTC) #5
apavlov
The CQ bit was unchecked by apavlov@chromium.org
6 years, 8 months ago (2014-04-01 11:39:54 UTC) #6
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 8 months ago (2014-04-01 11:40:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/218993012/20001
6 years, 8 months ago (2014-04-01 11:40:08 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 12:51:14 UTC) #9
Message was sent while issue was closed. 
Change committed as 170555

Powered by Google App Engine
This is Rietveld 408576698