Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingValidationCheck.java - Issue 218993012: DevTools: [JsDocValidator] Handle types declared as top-level vars

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingValidationCheck.java

Issue 218993012: DevTools: [JsDocValidator] Handle types declared as top-level vars (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Move case to keep the order consistent between methods Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/AstUtil.java ('k') | Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ReturnAnnotationChecker.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingValidationCheck.java

diff --git a/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingValidationCheck.java b/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingValidationCheck.java

index f468175c2d9f3dd1c6ef1b90113e642e80ad8c30..acce0b8cb36246fab01f5baab4a53a8fb873e04c 100644

--- a/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingValidationCheck.java

+++ b/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingValidationCheck.java

@@ -195,7 +195,9 @@ public class ContextTrackingValidationCheck extends ValidationCheck {

List<InheritanceEntry> result = new ArrayList<>(2);

Matcher matcher = EXTENDS_PATTERN.matcher(getNodeText(jsDocNode));

while (matcher.find()) {

- result.add(new InheritanceEntry(matcher.group(1), jsDocNode, matcher.start(1)));

+ String fullSuperType = matcher.group(1);

+ result.add(new InheritanceEntry(

+ fullSuperType.replaceFirst("\\.<.+>", ""), jsDocNode, matcher.start(1)));

}

return result;