Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8046)

Unified Diff: chrome/browser/ui/views/passwords/manage_password_item_view.cc

Issue 218993006: Extracting the remaining ManagePasswordsBubbleView::Init code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: vabr feedback. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/manage_password_item_view.cc
diff --git a/chrome/browser/ui/views/passwords/manage_password_item_view.cc b/chrome/browser/ui/views/passwords/manage_password_item_view.cc
index 0e1f553edb49d963b6b024bb1db48112df125178..dbe5fd8e0338394a499e15d9d9b39c29982a1460 100644
--- a/chrome/browser/ui/views/passwords/manage_password_item_view.cc
+++ b/chrome/browser/ui/views/passwords/manage_password_item_view.cc
@@ -17,7 +17,8 @@ ManagePasswordItemView::ManagePasswordItemView(
ManagePasswordsBubbleModel* manage_passwords_bubble_model,
autofill::PasswordForm password_form,
int field_1_width,
- int field_2_width)
+ int field_2_width,
+ Position position)
: manage_passwords_bubble_model_(manage_passwords_bubble_model),
password_form_(password_form),
delete_password_(false),
@@ -27,6 +28,17 @@ ManagePasswordItemView::ManagePasswordItemView(
ui::ResourceBundle* rb = &ui::ResourceBundle::GetSharedInstance();
SetLayoutManager(layout);
+ // When a password is displayed as the first item in a list, it has borders
+ // on both the top and bottom. When it's in the middle of a list, or at the
+ // end, it has a border only on the bottom.
+ SetBorder(views::Border::CreateSolidSidedBorder(
+ position == FIRST_ITEM ? 1 : 0,
+ 0,
markusheintz_ 2014/04/04 14:56:25 nit: I wonder whether we should add a comment or j
+ 1,
+ 0,
+ GetNativeTheme()->GetSystemColor(
+ ui::NativeTheme::kColorId_EnabledMenuButtonBorderColor)));
+
// Build the columnset we need for the current state of the model.
int column_set_to_build =
!manage_passwords_bubble_model_->WaitingToSavePassword()

Powered by Google App Engine
This is Rietveld 408576698