Extracting the remaining ManagePasswordsBubbleView::Init code.

chrome/browser/ui/views/passwords/manage_password_item_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/passwords/manage_password_item_view.h"
 
 #include "grit/generated_resources.h"
 #include "grit/ui_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/views/controls/button/button.h"
 #include "ui/views/controls/button/image_button.h"
 #include "ui/views/layout/grid_layout.h"
 #include "ui/views/layout/layout_constants.h"
 
 ManagePasswordItemView::ManagePasswordItemView(
     ManagePasswordsBubbleModel* manage_passwords_bubble_model,
     autofill::PasswordForm password_form,
     int field_1_width,
-    int field_2_width)
+    int field_2_width,
+    Position position)
     : manage_passwords_bubble_model_(manage_passwords_bubble_model),
       password_form_(password_form),
       delete_password_(false),
       field_1_width_(field_1_width),
       field_2_width_(field_2_width) {
   views::GridLayout* layout = new views::GridLayout(this);
   ui::ResourceBundle* rb = &ui::ResourceBundle::GetSharedInstance();
   SetLayoutManager(layout);
 
+  // When a password is displayed as the first item in a list, it has borders
+  // on both the top and bottom. When it's in the middle of a list, or at the
+  // end, it has a border only on the bottom.
+  SetBorder(views::Border::CreateSolidSidedBorder(
+      position == FIRST_ITEM ? 1 : 0,
+      0,

[markusheintz_, 2014/04/04 14:56:25]

nit: I wonder whether we should add a comment or just the argument name to
describe these numbers

+      1,
+      0,
+      GetNativeTheme()->GetSystemColor(
+          ui::NativeTheme::kColorId_EnabledMenuButtonBorderColor)));
+
   // Build the columnset we need for the current state of the model.
   int column_set_to_build =
       !manage_passwords_bubble_model_->WaitingToSavePassword()
           ? COLUMN_SET_MANAGE
           : COLUMN_SET_SAVE;
   BuildColumnSet(layout, column_set_to_build);
   layout->StartRowWithPadding(
       0, column_set_to_build, 0, views::kRelatedControlVerticalSpacing);
 
   // Add the username field: fills the first non-padding column of the layout.
@@ skipping 131 matching lines @@
   delete_password_ = true;
   Refresh();
 }
 
 void ManagePasswordItemView::LinkClicked(views::Link* source,
                                          int event_flags) {
   DCHECK_EQ(source, label_2_);
   delete_password_ = false;
   Refresh();
 }