Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1139)

Unified Diff: cc/test/animation_timelines_test_common.cc

Issue 2189813002: ElementAnimations should hold an ObservableList of AnimationPlayers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: apply loyso's comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/test/animation_timelines_test_common.cc
diff --git a/cc/test/animation_timelines_test_common.cc b/cc/test/animation_timelines_test_common.cc
index e9377635582c17dcfc4ceeaad7445f4a76c15594..559feed217fa3b6ff5f0216e0f239747309174fb 100644
--- a/cc/test/animation_timelines_test_common.cc
+++ b/cc/test/animation_timelines_test_common.cc
@@ -495,16 +495,22 @@ AnimationPlayer* AnimationTimelinesTest::GetPlayerForElementId(
ElementId element_id) {
const scoped_refptr<ElementAnimations> element_animations =
host_->GetElementAnimationsForElementId(element_id);
- return element_animations ? element_animations->players_list().head()->value()
- : nullptr;
+ return element_animations
+ ? base::ObserverList<AnimationPlayer>::Iterator(
loyso (OOO) 2016/08/05 00:18:48 ElementAnimations::PlayersList type here and every
ymalik 2016/08/05 00:54:05 Done.
+ &element_animations->players_list())
+ .GetNext()
+ : nullptr;
}
AnimationPlayer* AnimationTimelinesTest::GetImplPlayerForLayerId(
ElementId element_id) {
const scoped_refptr<ElementAnimations> element_animations =
host_impl_->GetElementAnimationsForElementId(element_id);
- return element_animations ? element_animations->players_list().head()->value()
- : nullptr;
+ return element_animations
+ ? base::ObserverList<AnimationPlayer>::Iterator(
+ &element_animations->players_list())
+ .GetNext()
+ : nullptr;
}
int AnimationTimelinesTest::NextTestLayerId() {

Powered by Google App Engine
This is Rietveld 408576698