Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: third_party/WebKit/Source/platform/animation/CompositorAnimationPlayerTest.cpp

Issue 2189813002: ElementAnimations should hold an ObservableList of AnimationPlayers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: apply loyso's comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/animation/CompositorAnimationPlayerTest.cpp
diff --git a/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayerTest.cpp b/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayerTest.cpp
index daa8206dc7cac27c65eb85a016064639f45ea6f7..25f97380687f0d3fccc5e66395efdde3163b6459 100644
--- a/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayerTest.cpp
+++ b/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayerTest.cpp
@@ -62,13 +62,13 @@ TEST_F(CompositorAnimationPlayerTest, NullDelegate)
player->setAnimationDelegate(delegate.get());
EXPECT_FALSE(delegate->m_finished);
- ccPlayer->NotifyAnimationFinished(base::TimeTicks(), CompositorTargetProperty::SCROLL_OFFSET, 0);
+ ccPlayer->OnAnimationFinished(base::TimeTicks(), CompositorTargetProperty::SCROLL_OFFSET, 0);
EXPECT_TRUE(delegate->m_finished);
delegate->resetFlags();
player->setAnimationDelegate(nullptr);
- ccPlayer->NotifyAnimationFinished(base::TimeTicks(), CompositorTargetProperty::SCROLL_OFFSET, 0);
+ ccPlayer->OnAnimationFinished(base::TimeTicks(), CompositorTargetProperty::SCROLL_OFFSET, 0);
EXPECT_FALSE(delegate->m_finished);
}
@@ -86,7 +86,7 @@ TEST_F(CompositorAnimationPlayerTest, NotifyFromCCAfterCompositorPlayerDeletion)
player = nullptr;
// No notifications. Doesn't crash.
- ccPlayer->NotifyAnimationFinished(base::TimeTicks(), CompositorTargetProperty::OPACITY, 0);
+ ccPlayer->OnAnimationFinished(base::TimeTicks(), CompositorTargetProperty::OPACITY, 0);
EXPECT_FALSE(delegate->m_finished);
}
« cc/test/animation_timelines_test_common.cc ('K') | « cc/test/animation_timelines_test_common.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698