Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2189733002:
[Devtools] Fix closure compiler (Closed)
|
Created:
4 years, 4 months ago by allada Modified:
4 years, 4 months ago CC:
chromium-reviews, caseq+blink_chromium.org, aboxhall, aboxhall+watch_chromium.org, nektar+watch_chromium.org, lushnikov+blink_chromium.org, yuzo+watch_chromium.org, pfeldman+blink_chromium.org, nektarios, je_julie, apavlov+blink_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, dmazzoni, kozyatinskiy+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Devtools] Fix closure compiler
Fixes closure compiler error caused by the following patches landing at
once:
https://codereview.chromium.org/2058323002
https://codereview.chromium.org/2181123002
BUG=none
Committed: https://crrev.com/b4cd5143b58e9a20d27afce63ad0117288294ec3
Cr-Commit-Position: refs/heads/master@{#408256}
Patch Set 1 : [Devtools] Fix closure compiler #
Messages
Total messages: 23 (15 generated)
Description was changed from ========== [Devtools] Fix closure compiler Fixes closure compiler erro caused by the following patches landing at once: https://codereview.chromium.org/2058323002 https://codereview.chromium.org/2181123002 BUG= ========== to ========== [Devtools] Fix closure compiler Fixes closure compiler error caused by the following patches landing at once: https://codereview.chromium.org/2058323002 https://codereview.chromium.org/2181123002 BUG= ==========
The CQ bit was checked by allada@chromium.org to run a CQ dry run
Patchset #1 (id:1) has been deleted
The CQ bit was checked by allada@chromium.org to run a CQ dry run
allada@chromium.org changed reviewers: + lushnikov@chromium.org
PTL
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
allada@chromium.org changed reviewers: + aboxhall@chromium.org
PTL
lgtm, thanks nit: either remove "BUG=" line in the issue description or do "BUG=none"
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [Devtools] Fix closure compiler Fixes closure compiler error caused by the following patches landing at once: https://codereview.chromium.org/2058323002 https://codereview.chromium.org/2181123002 BUG= ========== to ========== [Devtools] Fix closure compiler Fixes closure compiler error caused by the following patches landing at once: https://codereview.chromium.org/2058323002 https://codereview.chromium.org/2181123002 BUG=none ==========
The CQ bit was checked by allada@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by allada@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Devtools] Fix closure compiler Fixes closure compiler error caused by the following patches landing at once: https://codereview.chromium.org/2058323002 https://codereview.chromium.org/2181123002 BUG=none ========== to ========== [Devtools] Fix closure compiler Fixes closure compiler error caused by the following patches landing at once: https://codereview.chromium.org/2058323002 https://codereview.chromium.org/2181123002 BUG=none ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Devtools] Fix closure compiler Fixes closure compiler error caused by the following patches landing at once: https://codereview.chromium.org/2058323002 https://codereview.chromium.org/2181123002 BUG=none ========== to ========== [Devtools] Fix closure compiler Fixes closure compiler error caused by the following patches landing at once: https://codereview.chromium.org/2058323002 https://codereview.chromium.org/2181123002 BUG=none Committed: https://crrev.com/b4cd5143b58e9a20d27afce63ad0117288294ec3 Cr-Commit-Position: refs/heads/master@{#408256} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b4cd5143b58e9a20d27afce63ad0117288294ec3 Cr-Commit-Position: refs/heads/master@{#408256} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
