DevTools: Remove unused parameters to TextPrompt._loadCompletions callback

Remove unused parameters to TextPrompt._loadCompletions callback

Committed: https://crrev.com/017986cf841346d5eb71891daf4dfac4c27e2f22
Cr-Commit-Position: refs/heads/master@{#408158}

[aboxhall, 2016-07-25 23:00:31]

The CQ bit was checked by aboxhall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 23:00:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aboxhall, 2016-07-25 23:01:56]

aboxhall@chromium.org changed reviewers:
+ lushnikov@chromium.org

[aboxhall, 2016-07-25 23:01:56]

As discussed; PTAL.

[commit-bot: I haz the power, 2016-07-26 00:11:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 00:11:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lushnikov, 2016-07-26 00:38:19]

Seems like this doesn't pass a few completion tests.

[lushnikov, 2016-07-26 00:39:24]

Could you please also add "DevTools:" prefix to the issue description, and
either remove "BUG=" or set it to none?

[aboxhall, 2016-07-26 16:59:58]

Description was changed from

==========
Remove unused parameters to TextPrompt._loadCompletions callback

BUG=
==========

to

==========
Remove unused parameters to TextPrompt._loadCompletions callback
==========

[aboxhall, 2016-07-26 17:00:24]

On 2016/07/26 00:39:24, lushnikov wrote:
> Could you please also add "DevTools:" prefix to the issue description, and
> either remove "BUG=" or set it to none?

Done, and tests fixed. PTAL.

[aboxhall, 2016-07-26 17:00:27]

The CQ bit was checked by aboxhall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 17:00:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 19:25:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 19:25:18]

Dry run: This issue passed the CQ dry run.

[aboxhall, 2016-07-26 19:59:46]

The CQ bit was checked by aboxhall@chromium.org

[aboxhall, 2016-07-26 19:59:53]

The CQ bit was unchecked by aboxhall@chromium.org

[lushnikov, 2016-07-26 22:22:58]

https://codereview.chromium.org/2181123002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js
(right):

https://codereview.chromium.org/2181123002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js:160:
var completions = wordRange.startOffset === 0 ?
[this._delegate.autocomplete(wordRange.toString().toLowerCase())] : [];
why .toLowerCase()? Query is case-sensitive

[aboxhall, 2016-07-26 22:32:23]

The CQ bit was checked by aboxhall@chromium.org to run a CQ dry run

[aboxhall, 2016-07-26 22:32:27]

https://codereview.chromium.org/2181123002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js
(right):

https://codereview.chromium.org/2181123002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js:160:
var completions = wordRange.startOffset === 0 ?
[this._delegate.autocomplete(wordRange.toString().toLowerCase())] : [];
On 2016/07/26 22:22:58, lushnikov wrote:
> why .toLowerCase()? Query is case-sensitive

No reason; I saw it somewhere else in a similar context and copied it. Removed.

[commit-bot: I haz the power, 2016-07-26 22:33:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2016-07-26 22:42:10]

thanks, lgtm

[commit-bot: I haz the power, 2016-07-27 00:15:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 00:15:25]

Dry run: This issue passed the CQ dry run.

[aboxhall, 2016-07-27 16:57:38]

The CQ bit was checked by aboxhall@chromium.org

[commit-bot: I haz the power, 2016-07-27 16:57:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 17:02:33]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-27 17:04:05]

Description was changed from

==========
Remove unused parameters to TextPrompt._loadCompletions callback
==========

to

==========
Remove unused parameters to TextPrompt._loadCompletions callback

Committed: https://crrev.com/017986cf841346d5eb71891daf4dfac4c27e2f22
Cr-Commit-Position: refs/heads/master@{#408158}
==========

[commit-bot: I haz the power, 2016-07-27 17:04:07]

Patchset 3 (id:??) landed as
https://crrev.com/017986cf841346d5eb71891daf4dfac4c27e2f22
Cr-Commit-Position: refs/heads/master@{#408158}