Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2189643004: Fix performance regression of heap snapshot generator that was (Closed)

Created:
4 years, 4 months ago by ulan
Modified:
4 years, 4 months ago
Reviewers:
alph
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix performance regression of heap snapshot generator that was introduced in https://crrev.com/72f884a19fa4434bba6fc0e013ec4ea0a2366893 The regression comes from adding the next weak field of AllocationSite as a hidden reference into the snapshot. Before 72f884 the reference was implicitly ignored because the body descriptor of AllocationSite did not include it. This patch explicitly skip the next weak field of AllocationSite. BUG=chromium:630027 Committed: https://crrev.com/ea45a210a62d24cdb6b17d6374ed7648691fa6c3 Cr-Commit-Position: refs/heads/master@{#38211}

Patch Set 1 #

Patch Set 2 : speculative fix of failing test #

Patch Set 3 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -12 lines) Patch
M src/profiler/heap-snapshot-generator.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/profiler/heap-snapshot-generator.cc View 4 chunks +17 lines, -8 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
ulan
PTAL. More context is in crbug.com/630027.
4 years, 4 months ago (2016-07-27 16:52:30 UTC) #2
alph
Thanks for fixing! lgtm
4 years, 4 months ago (2016-07-27 19:10:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189643004/1
4 years, 4 months ago (2016-07-27 19:10:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng/builds/5821) v8_win_nosnap_shared_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 4 months ago (2016-07-27 19:45:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189643004/40001
4 years, 4 months ago (2016-08-01 12:59:59 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-01 13:31:03 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 13:34:37 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ea45a210a62d24cdb6b17d6374ed7648691fa6c3
Cr-Commit-Position: refs/heads/master@{#38211}

Powered by Google App Engine
This is Rietveld 408576698