Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1121)

Unified Diff: src/profiler/heap-snapshot-generator.h

Issue 2189643004: Fix performance regression of heap snapshot generator that was (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/profiler/heap-snapshot-generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/profiler/heap-snapshot-generator.h
diff --git a/src/profiler/heap-snapshot-generator.h b/src/profiler/heap-snapshot-generator.h
index a6bc38570a33dc586cb4f50a4d2280ef5bc0568b..949df26cdef2fd0818573f355ff9e3f11c56e890 100644
--- a/src/profiler/heap-snapshot-generator.h
+++ b/src/profiler/heap-snapshot-generator.h
@@ -396,6 +396,8 @@ class V8HeapExplorer : public HeapEntriesAllocator {
void ExtractInternalReferences(JSObject* js_obj, int entry);
bool IsEssentialObject(Object* object);
+ bool IsEssentialHiddenReference(Object* parent, int field_offset);
+
void SetContextReference(HeapObject* parent_obj,
int parent,
String* reference_name,
@@ -419,10 +421,8 @@ class V8HeapExplorer : public HeapEntriesAllocator {
int index,
Object* child,
int field_offset = -1);
- void SetHiddenReference(HeapObject* parent_obj,
- int parent,
- int index,
- Object* child);
+ void SetHiddenReference(HeapObject* parent_obj, int parent, int index,
+ Object* child, int field_offset);
void SetWeakReference(HeapObject* parent_obj,
int parent,
const char* reference_name,
« no previous file with comments | « no previous file | src/profiler/heap-snapshot-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698