Stop calling SSL_get_session in SSLClientSocketImpl.

Stop calling SSL_get_session in SSLClientSocketImpl.

In TLS 1.3, sessions are post-handshake, so they must only come in the
callback. This change is a no-op in TLS 1.2.

Also update the key_exchange_info to use the new SSL-based APIs. Otherwise
calling GetSSLInfo during a renegotiation may have problems. The SSL-based
APIs internally also have the same problem, but we can fix that while we
can't change SSL_get_session's behavior.

BUG=630149
Committed: https://crrev.com/c269cc4baed868b167ad45838b4cc1ea6492b866
Cr-Commit-Position: refs/heads/master@{#408125}

[davidben, 2016-07-27 14:06:40]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 14:06:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[davidben, 2016-07-27 14:07:20]

davidben@chromium.org changed reviewers:
+ svaldez@chromium.org

[svaldez, 2016-07-27 14:09:31]

Update CL description for kex change.

[davidben, 2016-07-27 14:11:24]

Description was changed from

==========
Stop calling SSL_get_session in SSLClientSocketImpl.

In TLS 1.3, sessions are post-handshake, so they must only come in the
callback. This change is a no-op in TLS 1.2.

BUG=630149
==========

to

==========
Stop calling SSL_get_session in SSLClientSocketImpl.

In TLS 1.3, sessions are post-handshake, so they must only come in the
callback. This change is a no-op in TLS 1.2.

Also update the key_exchange_info to use the new SSL-based APIs. Otherwise
calling GetSSLInfo during a renegotiation may have problems. The SSL-based
APIs internally also have the same problem, but we can fix that while we
can't change SSL_get_session's behavior.

BUG=630149
==========

[davidben, 2016-07-27 14:11:41]

On 2016/07/27 14:09:31, svaldez wrote:
> Update CL description for kex change.

Done.

[chromium-reviews, 2016-07-27 14:14:49]

+1

On Wed, Jul 27, 2016, 10:11 AM <davidben@chromium.org> wrote:

> On 2016/07/27 14:09:31, svaldez wrote:
> > Update CL description for kex change.
>
> Done.
>
> https://codereview.chromium.org/2189613003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[svaldez, 2016-07-27 14:15:50]

lgtm

[davidben, 2016-07-27 14:16:04]

The CQ bit was unchecked by davidben@chromium.org

[davidben, 2016-07-27 14:16:08]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2016-07-27 14:16:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chromium-reviews, 2016-07-27 14:16:25]

lgtm

On Wed, Jul 27, 2016 at 10:15 AM <svaldez@chromium.org> wrote:

> lgtm
>
>
>
> https://codereview.chromium.org/2189613003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2016-07-27 14:55:17]

Description was changed from

==========
Stop calling SSL_get_session in SSLClientSocketImpl.

In TLS 1.3, sessions are post-handshake, so they must only come in the
callback. This change is a no-op in TLS 1.2.

Also update the key_exchange_info to use the new SSL-based APIs. Otherwise
calling GetSSLInfo during a renegotiation may have problems. The SSL-based
APIs internally also have the same problem, but we can fix that while we
can't change SSL_get_session's behavior.

BUG=630149
==========

to

==========
Stop calling SSL_get_session in SSLClientSocketImpl.

In TLS 1.3, sessions are post-handshake, so they must only come in the
callback. This change is a no-op in TLS 1.2.

Also update the key_exchange_info to use the new SSL-based APIs. Otherwise
calling GetSSLInfo during a renegotiation may have problems. The SSL-based
APIs internally also have the same problem, but we can fix that while we
can't change SSL_get_session's behavior.

BUG=630149
==========

[commit-bot: I haz the power, 2016-07-27 14:55:18]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-27 14:56:58]

Description was changed from

==========
Stop calling SSL_get_session in SSLClientSocketImpl.

In TLS 1.3, sessions are post-handshake, so they must only come in the
callback. This change is a no-op in TLS 1.2.

Also update the key_exchange_info to use the new SSL-based APIs. Otherwise
calling GetSSLInfo during a renegotiation may have problems. The SSL-based
APIs internally also have the same problem, but we can fix that while we
can't change SSL_get_session's behavior.

BUG=630149
==========

to

==========
Stop calling SSL_get_session in SSLClientSocketImpl.

In TLS 1.3, sessions are post-handshake, so they must only come in the
callback. This change is a no-op in TLS 1.2.

Also update the key_exchange_info to use the new SSL-based APIs. Otherwise
calling GetSSLInfo during a renegotiation may have problems. The SSL-based
APIs internally also have the same problem, but we can fix that while we
can't change SSL_get_session's behavior.

BUG=630149

Committed: https://crrev.com/c269cc4baed868b167ad45838b4cc1ea6492b866
Cr-Commit-Position: refs/heads/master@{#408125}
==========

[commit-bot: I haz the power, 2016-07-27 14:56:59]

Patchset 1 (id:??) landed as
https://crrev.com/c269cc4baed868b167ad45838b4cc1ea6492b866
Cr-Commit-Position: refs/heads/master@{#408125}