Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1348)

Unified Diff: net/socket/ssl_client_socket_impl.h

Issue 2189613003: Stop calling SSL_get_session in SSLClientSocketImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/socket/ssl_client_socket_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/ssl_client_socket_impl.h
diff --git a/net/socket/ssl_client_socket_impl.h b/net/socket/ssl_client_socket_impl.h
index e9554d498098c19eef3bb8ba5f02aaccbb2c36bc..fea969c3e8f68aa3107af394e27418d369001b6c 100644
--- a/net/socket/ssl_client_socket_impl.h
+++ b/net/socket/ssl_client_socket_impl.h
@@ -28,6 +28,7 @@
#include "net/socket/ssl_client_socket.h"
#include "net/ssl/channel_id_service.h"
#include "net/ssl/openssl_ssl_util.h"
+#include "net/ssl/scoped_openssl_types.h"
#include "net/ssl/ssl_client_cert_type.h"
#include "net/ssl/ssl_config_service.h"
@@ -345,10 +346,9 @@ class SSLClientSocketImpl : public SSLClientSocket {
std::unique_ptr<crypto::ECPrivateKey> channel_id_key_;
// True if a channel ID was sent.
bool channel_id_sent_;
- // True if the current session was newly-established, but the certificate had
- // not yet been verified externally, so it cannot be inserted into the cache
- // until later.
- bool session_pending_;
+ // If non-null, the newly-established to be inserted into the session cache
+ // once certificate verification is done.
+ ScopedSSL_SESSION pending_session_;
// True if the initial handshake's certificate has been verified.
bool certificate_verified_;
// The request handle for |channel_id_service_|.
« no previous file with comments | « no previous file | net/socket/ssl_client_socket_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698