Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2189583002: Fix generate-bytecode-expectations crash (Closed)

Created:
4 years, 4 months ago by klaasb
Modified:
4 years, 4 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix generate-bytecode-expectations crash https://codereview.chromium.org/2176143002 removed parsing of a golden file header option but did not remove the option. BUG= LOG=n Committed: https://crrev.com/d1baa31e52313b3e9466a6192939bb2af43d5dec Cr-Commit-Position: refs/heads/master@{#38096}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
klaasb
4 years, 4 months ago (2016-07-27 11:21:48 UTC) #3
rmcilroy
lgtm
4 years, 4 months ago (2016-07-27 11:33:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189583002/1
4 years, 4 months ago (2016-07-27 12:00:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 12:21:15 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d1baa31e52313b3e9466a6192939bb2af43d5dec Cr-Commit-Position: refs/heads/master@{#38096}
4 years, 4 months ago (2016-07-27 12:23:23 UTC) #10
neis
4 years, 4 months ago (2016-07-27 13:12:48 UTC) #11
Message was sent while issue was closed.
Thanks!

Powered by Google App Engine
This is Rietveld 408576698