Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2176143002: Remove the --ignition-generators flag. (Closed)

Created:
4 years, 4 months ago by neis
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, oth, rmcilroy, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove the --ignition-generators flag. This flag has been enabled by default for over a month now. R=mstarzinger@chromium.org, rmcilroy@chromium.org BUG= Committed: https://crrev.com/88a795d1c80feaaae4d0865e9c5d8e363c904704 Cr-Commit-Position: refs/heads/master@{#38020}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -59 lines) Patch
M src/compiler.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/interpreter/generate-bytecode-expectations.cc View 8 chunks +0 lines, -10 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M test/js-perf-test/JSTests.json View 2 chunks +1 line, -3 lines 0 comments Download
M test/message/generators-throw1.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/message/generators-throw1.out View 1 chunk +1 line, -1 line 0 comments Download
M test/message/generators-throw2.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/message/generators-throw2.out View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-generator-break.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-generator-break-on-stack.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-stepin-generators.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/generators-debug-liveedit.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/generators-debug-scopes.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/generators-iteration.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/generators-mirror.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/generators-objects.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/generators-parsing.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/generators-poisoned-properties.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/generators-relocation.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/generators-runtime.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/generators-states.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/harmony/debug-async-liveedit.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/generators.js View 1 chunk +1 line, -2 lines 0 comments Download
M test/mjsunit/harmony/generators-turbo.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/regress/regress-618603.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-618657.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
neis
4 years, 4 months ago (2016-07-25 12:17:52 UTC) #1
rmcilroy
LGTM, thanks for the cleanup!
4 years, 4 months ago (2016-07-25 12:22:59 UTC) #2
Michael Starzinger
LGTM from my end. Please wait on sign-off from Ross as well.
4 years, 4 months ago (2016-07-25 12:23:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176143002/1
4 years, 4 months ago (2016-07-25 12:25:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-25 12:55:25 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-07-25 12:56:35 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/88a795d1c80feaaae4d0865e9c5d8e363c904704
Cr-Commit-Position: refs/heads/master@{#38020}

Powered by Google App Engine
This is Rietveld 408576698