Fix TimeDomain::MigrateQueue with incoming immediate tasks

Fix TimeDomain::MigrateQueue with incoming immediate tasks

There's a bug with TimeDomain::MigrateQueue, it should add the TaskQueue
to the destination_time_domain's updatable_queue_set_ if the queue was
updatable.  Not doing so runs the risk of incoming tasks never running,
unless a subsequent immediate task is posted to the queue.

Note to Perf sheriffs.  I'm not expecting any regressions with
this patch, but it's possible some tasks that were previously
not running are running now.  If that causes a regression it's
working as intended.

BUG=631941, 546953
Committed: https://crrev.com/fada7593e93c5a07ec3cbbb5cee01eaf78d421cf
Cr-Commit-Position: refs/heads/master@{#408098}

[alex clarke (OOO till 29th), 2016-07-27 09:52:38]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[alex clarke (OOO till 29th), 2016-07-27 09:52:47]

alexclarke@chromium.org changed reviewers:
+ skyostil@chromium.org

[commit-bot: I haz the power, 2016-07-27 09:52:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sami, 2016-07-27 09:57:56]

lgtm, thanks for the fix. Btw you probably meant "updatable" instead
"migratable" in the patch description.

https://codereview.chromium.org/2189573002/diff/1/components/scheduler/base/t...
File components/scheduler/base/task_queue_manager_unittest.cc (right):

https://codereview.chromium.org/2189573002/diff/1/components/scheduler/base/t...
components/scheduler/base/task_queue_manager_unittest.cc:1630:
TEST_F(TaskQueueManagerTest, TimeDomainMigrationWithIncommingImmediateTasks) {
s/incomming/incoming/

https://codereview.chromium.org/2189573002/diff/1/components/scheduler/base/t...
File components/scheduler/base/time_domain.cc (right):

https://codereview.chromium.org/2189573002/diff/1/components/scheduler/base/t...
components/scheduler/base/time_domain.cc:51: // Make sure we remember to update
|queue| if it's got incomming immediate
s/incomming/incoming/

[alex clarke (OOO till 29th), 2016-07-27 10:11:04]

Description was changed from

==========
Fix TimeDomain::MigrateQueue with incoming immediate tasks

There's a bug with TimeDomain::MigrateQueue, it should add the TaskQueue
to the destination_time_domain's updatable_queue_set_ if the queue was
migratable.  Not doing so runs the risk of incoming tasks never running,
unless a subsequent immediate task is posted to the queue.

BUG=631941, 546953
==========

to

==========
Fix TimeDomain::MigrateQueue with incoming immediate tasks

There's a bug with TimeDomain::MigrateQueue, it should add the TaskQueue
to the destination_time_domain's updatable_queue_set_ if the queue was
updatable.  Not doing so runs the risk of incoming tasks never running,
unless a subsequent immediate task is posted to the queue.

BUG=631941, 546953
==========

[alex clarke (OOO till 29th), 2016-07-27 10:14:30]

Description was changed from

==========
Fix TimeDomain::MigrateQueue with incoming immediate tasks

There's a bug with TimeDomain::MigrateQueue, it should add the TaskQueue
to the destination_time_domain's updatable_queue_set_ if the queue was
updatable.  Not doing so runs the risk of incoming tasks never running,
unless a subsequent immediate task is posted to the queue.

BUG=631941, 546953
==========

to

==========
Fix TimeDomain::MigrateQueue with incoming immediate tasks

There's a bug with TimeDomain::MigrateQueue, it should add the TaskQueue
to the destination_time_domain's updatable_queue_set_ if the queue was
updatable.  Not doing so runs the risk of incoming tasks never running,
unless a subsequent immediate task is posted to the queue.

Note to Perf sheriffs.  I'm not expecting any regressions with
this patch, but it's possible some tasks that were previously
not running are running now.  If that causes a regression it's 
working as intended. 

BUG=631941, 546953
==========

[alex clarke (OOO till 29th), 2016-07-27 10:14:56]

All done

https://codereview.chromium.org/2189573002/diff/1/components/scheduler/base/t...
File components/scheduler/base/task_queue_manager_unittest.cc (right):

https://codereview.chromium.org/2189573002/diff/1/components/scheduler/base/t...
components/scheduler/base/task_queue_manager_unittest.cc:1630:
TEST_F(TaskQueueManagerTest, TimeDomainMigrationWithIncommingImmediateTasks) {
On 2016/07/27 09:57:56, Sami wrote:
> s/incomming/incoming/

Done.

https://codereview.chromium.org/2189573002/diff/1/components/scheduler/base/t...
File components/scheduler/base/time_domain.cc (right):

https://codereview.chromium.org/2189573002/diff/1/components/scheduler/base/t...
components/scheduler/base/time_domain.cc:51: // Make sure we remember to update
|queue| if it's got incomming immediate
On 2016/07/27 09:57:56, Sami wrote:
> s/incomming/incoming/

Done.

[alex clarke (OOO till 29th), 2016-07-27 10:15:00]

The CQ bit was checked by alexclarke@chromium.org

[alex clarke (OOO till 29th), 2016-07-27 10:15:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2189573002/#ps20001
(title: "Fix nits")

[commit-bot: I haz the power, 2016-07-27 10:15:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 12:09:16]

Description was changed from

==========
Fix TimeDomain::MigrateQueue with incoming immediate tasks

There's a bug with TimeDomain::MigrateQueue, it should add the TaskQueue
to the destination_time_domain's updatable_queue_set_ if the queue was
updatable.  Not doing so runs the risk of incoming tasks never running,
unless a subsequent immediate task is posted to the queue.

Note to Perf sheriffs.  I'm not expecting any regressions with
this patch, but it's possible some tasks that were previously
not running are running now.  If that causes a regression it's 
working as intended. 

BUG=631941, 546953
==========

to

==========
Fix TimeDomain::MigrateQueue with incoming immediate tasks

There's a bug with TimeDomain::MigrateQueue, it should add the TaskQueue
to the destination_time_domain's updatable_queue_set_ if the queue was
updatable.  Not doing so runs the risk of incoming tasks never running,
unless a subsequent immediate task is posted to the queue.

Note to Perf sheriffs.  I'm not expecting any regressions with
this patch, but it's possible some tasks that were previously
not running are running now.  If that causes a regression it's 
working as intended. 

BUG=631941, 546953
==========

[commit-bot: I haz the power, 2016-07-27 12:09:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-27 12:11:18]

Description was changed from

==========
Fix TimeDomain::MigrateQueue with incoming immediate tasks

There's a bug with TimeDomain::MigrateQueue, it should add the TaskQueue
to the destination_time_domain's updatable_queue_set_ if the queue was
updatable.  Not doing so runs the risk of incoming tasks never running,
unless a subsequent immediate task is posted to the queue.

Note to Perf sheriffs.  I'm not expecting any regressions with
this patch, but it's possible some tasks that were previously
not running are running now.  If that causes a regression it's 
working as intended. 

BUG=631941, 546953
==========

to

==========
Fix TimeDomain::MigrateQueue with incoming immediate tasks

There's a bug with TimeDomain::MigrateQueue, it should add the TaskQueue
to the destination_time_domain's updatable_queue_set_ if the queue was
updatable.  Not doing so runs the risk of incoming tasks never running,
unless a subsequent immediate task is posted to the queue.

Note to Perf sheriffs.  I'm not expecting any regressions with
this patch, but it's possible some tasks that were previously
not running are running now.  If that causes a regression it's
working as intended.

BUG=631941, 546953

Committed: https://crrev.com/fada7593e93c5a07ec3cbbb5cee01eaf78d421cf
Cr-Commit-Position: refs/heads/master@{#408098}
==========

[commit-bot: I haz the power, 2016-07-27 12:11:19]

Patchset 2 (id:??) landed as
https://crrev.com/fada7593e93c5a07ec3cbbb5cee01eaf78d421cf
Cr-Commit-Position: refs/heads/master@{#408098}