Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Side by Side Diff: components/scheduler/base/task_queue_manager_unittest.cc

Issue 2189573002: Fix TimeDomain::MigrateQueue with incoming immediate tasks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix nits Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/scheduler/base/time_domain.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/scheduler/base/task_queue_manager.h" 5 #include "components/scheduler/base/task_queue_manager.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <utility> 9 #include <utility>
10 10
(...skipping 1609 matching lines...) Expand 10 before | Expand all | Expand 10 after
1620 1620
1621 test_task_runner_->RunUntilIdle(); 1621 test_task_runner_->RunUntilIdle();
1622 EXPECT_THAT(run_order, ElementsAre(1, 2, 3, 4)); 1622 EXPECT_THAT(run_order, ElementsAre(1, 2, 3, 4));
1623 1623
1624 runners_[0]->UnregisterTaskQueue(); 1624 runners_[0]->UnregisterTaskQueue();
1625 1625
1626 manager_->UnregisterTimeDomain(domain_a.get()); 1626 manager_->UnregisterTimeDomain(domain_a.get());
1627 manager_->UnregisterTimeDomain(domain_b.get()); 1627 manager_->UnregisterTimeDomain(domain_b.get());
1628 } 1628 }
1629 1629
1630 TEST_F(TaskQueueManagerTest, TimeDomainMigrationWithIncomingImmediateTasks) {
1631 Initialize(1u);
1632
1633 base::TimeTicks start_time = manager_->delegate()->NowTicks();
1634 std::unique_ptr<VirtualTimeDomain> domain_a(
1635 new VirtualTimeDomain(nullptr, start_time));
1636 std::unique_ptr<VirtualTimeDomain> domain_b(
1637 new VirtualTimeDomain(nullptr, start_time));
1638 manager_->RegisterTimeDomain(domain_a.get());
1639 manager_->RegisterTimeDomain(domain_b.get());
1640
1641 runners_[0]->SetTimeDomain(domain_a.get());
1642 std::vector<EnqueueOrder> run_order;
1643 runners_[0]->PostTask(FROM_HERE, base::Bind(&TestTask, 1, &run_order));
1644 runners_[0]->SetTimeDomain(domain_b.get());
1645
1646 test_task_runner_->RunUntilIdle();
1647 EXPECT_THAT(run_order, ElementsAre(1));
1648
1649 runners_[0]->UnregisterTaskQueue();
1650
1651 manager_->UnregisterTimeDomain(domain_a.get());
1652 manager_->UnregisterTimeDomain(domain_b.get());
1653 }
1654
1630 namespace { 1655 namespace {
1631 void ChromiumRunloopInspectionTask( 1656 void ChromiumRunloopInspectionTask(
1632 scoped_refptr<cc::OrderedSimpleTaskRunner> test_task_runner) { 1657 scoped_refptr<cc::OrderedSimpleTaskRunner> test_task_runner) {
1633 EXPECT_EQ(1u, test_task_runner->NumPendingTasks()); 1658 EXPECT_EQ(1u, test_task_runner->NumPendingTasks());
1634 } 1659 }
1635 } // namespace 1660 } // namespace
1636 1661
1637 TEST_F(TaskQueueManagerTest, NumberOfPendingTasksOnChromiumRunLoop) { 1662 TEST_F(TaskQueueManagerTest, NumberOfPendingTasksOnChromiumRunLoop) {
1638 Initialize(1u); 1663 Initialize(1u);
1639 1664
(...skipping 334 matching lines...) Expand 10 before | Expand all | Expand 10 after
1974 1999
1975 trace_analyzer::TraceEventVector events; 2000 trace_analyzer::TraceEventVector events;
1976 Query q = Query::EventPhaseIs(TRACE_EVENT_PHASE_ENTER_CONTEXT) || 2001 Query q = Query::EventPhaseIs(TRACE_EVENT_PHASE_ENTER_CONTEXT) ||
1977 Query::EventPhaseIs(TRACE_EVENT_PHASE_LEAVE_CONTEXT); 2002 Query::EventPhaseIs(TRACE_EVENT_PHASE_LEAVE_CONTEXT);
1978 analyzer->FindEvents(q, &events); 2003 analyzer->FindEvents(q, &events);
1979 2004
1980 EXPECT_EQ(2u, events.size()); 2005 EXPECT_EQ(2u, events.size());
1981 } 2006 }
1982 2007
1983 } // namespace scheduler 2008 } // namespace scheduler
OLDNEW
« no previous file with comments | « no previous file | components/scheduler/base/time_domain.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698