Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2507)

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

Issue 2189543002: Notify page load metrics when the app enters the background. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@clankbackgroundcallback
Patch Set: guard against null webcontents Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
index 7a9383e415b3ac539e902283ed1f1bdd2ba553c3..a9d028471b4f07b00614aa830c7c0682da2539dc 100644
--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
@@ -472,4 +472,31 @@ TEST_F(MetricsWebContentsObserverTest, LogAbortChainsNoCommit) {
histogram_tester_.ExpectBucketCount(internal::kAbortChainSizeNoCommit, 3, 1);
}
+TEST_F(MetricsWebContentsObserverTest, FlushMetricsOnAppEnterBackground) {
+ content::WebContentsTester* web_contents_tester =
+ content::WebContentsTester::For(web_contents());
+ web_contents_tester->NavigateAndCommit(GURL(kDefaultTestUrl));
+
+ histogram_tester_.ExpectTotalCount(
+ internal::kPageLoadCompletedAfterAppBackground, 0);
+
+ observer_->FlushMetricsOnAppEnterBackground();
+
+ histogram_tester_.ExpectTotalCount(
+ internal::kPageLoadCompletedAfterAppBackground, 1);
+ histogram_tester_.ExpectBucketCount(
+ internal::kPageLoadCompletedAfterAppBackground, false, 1);
+ histogram_tester_.ExpectBucketCount(
+ internal::kPageLoadCompletedAfterAppBackground, true, 0);
+
+ observer_.reset();
+
+ histogram_tester_.ExpectTotalCount(
+ internal::kPageLoadCompletedAfterAppBackground, 2);
+ histogram_tester_.ExpectBucketCount(
+ internal::kPageLoadCompletedAfterAppBackground, false, 1);
+ histogram_tester_.ExpectBucketCount(
+ internal::kPageLoadCompletedAfterAppBackground, true, 1);
+}
+
} // namespace page_load_metrics

Powered by Google App Engine
This is Rietveld 408576698