tools/metrics/histograms/histograms.xml - Issue 2189543002: Notify page load metrics when the app enters the background.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2189543002: Notify page load metrics when the app enters the background. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@clankbackgroundcallback

Patch Set: guard against null webcontents Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index daf27f8b2df08bb09fb1f688ce9baab0c31ec5f8..d513a7d5ad3bb65a0fcb32f250f54f3ecdd26cc9 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -37827,6 +37827,22 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="PageLoad.Internal.PageLoadCompleted.AfterAppBackground"

+ enum="Boolean">

Alexei Svitkine (slow) 2016/07/29 17:31:27 Please use a more specific enum, which you can def

Bryan McQuade 2016/07/29 17:48:10 Sure, done.

+ <owner>bmcquade@chromium.org</owner>

+ <summary>

+ Whether a page load completed after the app entered the background. We log a

+ 'false' value for each PageLoadTracker that is active when the app enters

+ the background, and a 'true' value for each of those PageLoadTrackers that

+ successfully runs its destructor. This helps to understand how many trackers

+ are destroyed while the app is in the background before they are able to run

+ their destructor. This metric is only intended to help in understanding how

+ often app background leads to data loss, and will be deprecated in a

+ subsequent release. Please contact bmcquade@chromium.org before using this

+ metric.

+ </summary>

+</histogram>

<histogram name="PageLoad.Internal.ProvisionalAbortChainSize.ForwardBack"

units="length">

<owner>csharrison@chromium.org</owner>

« chrome/browser/page_load_metrics/metrics_web_contents_observer.cc ('K') | « chrome/chrome_browser.gypi ('k') | no next file » | no next file with comments »