MD Settings: Internet: Clean up SIM info and dialog

MD Settings: Internet: Clean up SIM info and dialog

BUG=609156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/0fc289e6271fad8b89287ab1c66a8829c6dd5624
Cr-Commit-Position: refs/heads/master@{#409235}

[stevenjb, 2016-07-27 19:50:23]

Description was changed from

==========
MD Settings: Internet: Clean up SIM info and dialog

BUG=609156
==========

to

==========
MD Settings: Internet: Clean up SIM info and dialog

BUG=609156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2016-07-27 20:15:39]

stevenjb@chromium.org changed reviewers:
+ dschuyler@chromium.org

[stevenjb, 2016-07-27 20:15:40]

At your convenience.

[dschuyler, 2016-07-28 22:12:17]

https://codereview.chromium.org/2189523003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/network_siminfo.html
(right):

https://codereview.chromium.org/2189523003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_siminfo.html:6: <link
rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html">
Can these imports be alphabetized? I know that
at one point there were issues alphabetizing
the imports, but I think that may be addressed 
now.

https://codereview.chromium.org/2189523003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/network_siminfo.js (right):

https://codereview.chromium.org/2189523003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_siminfo.js:330:
getErrorMsg_: function(error, networkProperties) {
missing @param.
(may need to add file to compiled_resources.gyp).

[stevenjb, 2016-07-29 17:48:34]

https://codereview.chromium.org/2189523003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/network_siminfo.html
(right):

https://codereview.chromium.org/2189523003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_siminfo.html:6: <link
rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html">
On 2016/07/28 22:12:16, dschuyler wrote:
> Can these imports be alphabetized? I know that
> at one point there were issues alphabetizing
> the imports, but I think that may be addressed 
> now.

Done.

https://codereview.chromium.org/2189523003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/network_siminfo.js (right):

https://codereview.chromium.org/2189523003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_siminfo.js:330:
getErrorMsg_: function(error, networkProperties) {
On 2016/07/28 22:12:16, dschuyler wrote:
> missing @param.
> (may need to add file to compiled_resources.gyp).

I am going to remove networkProperties from all of these since it shadows a
declared property to be consistent with other internet code (as we discussed
offline).

[dschuyler, 2016-07-29 19:13:19]

LGTM with a nit

https://codereview.chromium.org/2189523003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/network_siminfo.js (right):

https://codereview.chromium.org/2189523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_siminfo.js:333: //
TODO(stevenjb_: Translate
// TODO(stevenjb): Translate

changing _ to )

[stevenjb, 2016-07-30 23:56:33]

Updated to use this. for all properties, ptal.

https://codereview.chromium.org/2189523003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/network_siminfo.js (right):

https://codereview.chromium.org/2189523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_siminfo.js:333: //
TODO(stevenjb_: Translate
On 2016/07/29 19:13:19, dschuyler wrote:
> // TODO(stevenjb): Translate
> 
> changing _ to )

Done.

[stevenjb, 2016-08-02 00:08:36]

And eliminated property parameters, PTAL.

[stevenjb, 2016-08-02 00:22:25]

Also included a minor fix for the cr-dialog elements.

[stevenjb, 2016-08-02 00:28:34]

Patchset #9 (id:160001) has been deleted

[dschuyler, 2016-08-02 02:29:15]

SLGTM

[stevenjb, 2016-08-02 16:44:40]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2016-08-02 16:44:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/2189523003/#ps200001
(title: "Also fix siminfo dialogs")

[commit-bot: I haz the power, 2016-08-02 16:45:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 17:57:31]

Committed patchset #10 (id:200001)

[commit-bot: I haz the power, 2016-08-02 18:00:20]

Description was changed from

==========
MD Settings: Internet: Clean up SIM info and dialog

BUG=609156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Internet: Clean up SIM info and dialog

BUG=609156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/0fc289e6271fad8b89287ab1c66a8829c6dd5624
Cr-Commit-Position: refs/heads/master@{#409235}
==========

[commit-bot: I haz the power, 2016-08-02 18:00:21]

Patchset 10 (id:??) landed as
https://crrev.com/0fc289e6271fad8b89287ab1c66a8829c6dd5624
Cr-Commit-Position: refs/heads/master@{#409235}