chrome/browser/resources/settings/internet_page/internet_detail_page.html - Issue 2189523003: MD Settings: Internet: Clean up SIM info and dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/internet_page/internet_detail_page.html

Issue 2189523003: MD Settings: Internet: Clean up SIM info and dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_609156_internet_cleanup_4

Patch Set: Also fix siminfo dialogs Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/settings/internet_page/internet_detail_page.html

diff --git a/chrome/browser/resources/settings/internet_page/internet_detail_page.html b/chrome/browser/resources/settings/internet_page/internet_detail_page.html

index 850e1252b824a74475c46b1e9456554ccfa38d9f..d5950a2f166c5a8db02b314cbf764bbdbfb99052 100644

--- a/chrome/browser/resources/settings/internet_page/internet_detail_page.html

+++ b/chrome/browser/resources/settings/internet_page/internet_detail_page.html

@@ -125,13 +125,12 @@

</div>

- <div class="settings-box self-stretch"

- hidden$="[[!showCellularSim_(networkProperties)]]">

- <network-siminfo editable network-properties="[[networkProperties]]"

- on-siminfo-change="onNetworkPropertyChange_"

- networking-private="[[networkingPrivate]]">

- </network-siminfo>

- </div>

+ <network-siminfo

+ editable on-siminfo-change="onNetworkPropertyChange_"

+ hidden$="[[!showCellularSim_(networkProperties)]]"

+ network-properties="[[networkProperties]]"

+ networking-private="[[networkingPrivate]]">

+ </network-siminfo>

« no previous file with comments | « no previous file | chrome/browser/resources/settings/internet_page/network_siminfo.html » ('j') | no next file with comments »