Blink: prevent didAssociateFormControls notification while parsing the document.

components/autofill/content/renderer/autofill_agent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/autofill_agent.h"
 
 #include <stddef.h>
 
 #include <tuple>
 
@@ skipping 797 matching lines @@
     return;
   is_popup_possibly_visible_ = false;
   is_generation_popup_possibly_visible_ = false;
   Send(new AutofillHostMsg_HidePopup(routing_id()));
 }
 
 bool AutofillAgent::IsUserGesture() const {
   return WebUserGestureIndicator::isProcessingUserGesture();
 }
 
-void AutofillAgent::didAssociateFormControls(const WebVector<WebNode>& nodes) {
-  for (size_t i = 0; i < nodes.size(); ++i) {
-    WebLocalFrame* frame = nodes[i].document().frame();
-    // Only monitors dynamic forms created in the top frame. Dynamic forms
-    // inserted in iframes are not captured yet. Frame is only processed
-    // if it has finished loading, otherwise you can end up with a partially
-    // parsed form.
-    if (frame && !frame->isLoading()) {
-      ProcessForms();
-      password_autofill_agent_->OnDynamicFormsSeen();
-      if (password_generation_agent_)
-        password_generation_agent_->OnDynamicFormsSeen();
-      return;
-    }
+void AutofillAgent::didAssociateFormControls() {
+  blink::WebLocalFrame* frame = render_frame()->GetWebFrame();
+
+  // Only monitors dynamic forms created in the top frame. Dynamic forms

[vabr (Chromium), 2016/07/27 14:06:49]

Have we now understood why the comment speaks about main frame only? Which part
of the code makes sure that this AutofillAgent instance is associated with the
main frame?

[vasilii, 2016/07/27 14:26:59]

Looks false to me.

+  // inserted in iframes are not captured yet. Frame is only processed
+  // if it has finished loading, otherwise you can end up with a partially
+  // parsed form.
+  if (frame && !frame->isLoading()) {
+    ProcessForms();
+    password_autofill_agent_->OnDynamicFormsSeen();
+    if (password_generation_agent_)
+      password_generation_agent_->OnDynamicFormsSeen();
   }
 }
 
 void AutofillAgent::ajaxSucceeded() {
   OnSamePageNavigationCompleted();
   password_autofill_agent_->AJAXSucceeded();
 }
 
 void AutofillAgent::ConnectToMojoAutofillDriverIfNeeded() {
   if (mojo_autofill_driver_.is_bound() &&
@@ skipping 21 matching lines @@
 void AutofillAgent::LegacyAutofillAgent::OnDestruct() {
   // No-op. Don't delete |this|.
 }
 
 void AutofillAgent::LegacyAutofillAgent::FocusChangeComplete() {
   if (agent_)
     agent_->FocusChangeComplete();
 }
 
 }  // namespace autofill