Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2189443004: Cleanup old TODOs that got done or are no longer relevant. (Closed)

Created:
4 years, 4 months ago by Pete Williamson
Modified:
4 years, 4 months ago
Reviewers:
dougarnett
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup old TODOs that got done or are no longer relevant. BUG=610521 Committed: https://crrev.com/3df75a1d847f616a8ed98aa4715333cbb5320b1d Cr-Commit-Position: refs/heads/master@{#408222}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M components/offline_pages/background/request_coordinator.cc View 3 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Pete Williamson
3 of the TODOs got done, just elsewhere in the code, and these didn't get ...
4 years, 4 months ago (2016-07-27 18:40:07 UTC) #2
dougarnett
lgtm
4 years, 4 months ago (2016-07-27 19:03:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189443004/1
4 years, 4 months ago (2016-07-27 19:24:04 UTC) #5
commit-bot: I haz the power
Failed to apply the patch.
4 years, 4 months ago (2016-07-27 20:02:46 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 20:04:50 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3df75a1d847f616a8ed98aa4715333cbb5320b1d
Cr-Commit-Position: refs/heads/master@{#408222}

Powered by Google App Engine
This is Rietveld 408576698