Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: components/offline_pages/background/request_coordinator.cc

Issue 2189443004: Cleanup old TODOs that got done or are no longer relevant. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/offline_pages/background/request_coordinator.cc
diff --git a/components/offline_pages/background/request_coordinator.cc b/components/offline_pages/background/request_coordinator.cc
index dd61539323d0c779345d2cbc2c97a561d349ef7c..dbe0316f74ccb9812c6c7699b12381fb33f5be8d 100644
--- a/components/offline_pages/background/request_coordinator.cc
+++ b/components/offline_pages/background/request_coordinator.cc
@@ -61,7 +61,6 @@ bool RequestCoordinator::SavePageLater(
static int64_t id = 0;
// Build a SavePageRequest.
- // TODO(petewil): Use something like base::Clock to help in testing.
offline_pages::SavePageRequest request(
id++, url, client_id, base::Time::Now(), was_user_requested);
@@ -76,8 +75,7 @@ void RequestCoordinator::AddRequestResultCallback(
RequestQueue::AddRequestResult result,
const SavePageRequest& request) {
- // Inform the scheduler that we have an outstanding task.
- // TODO(petewil): Determine trigger conditions from policy.
+ // Inform the scheduler that we have an outstanding task..
scheduler_->Schedule(GetTriggerConditionsForUserRequest());
}
@@ -121,8 +119,6 @@ bool RequestCoordinator::StartProcessing(
is_canceled_ = false;
scheduler_callback_ = callback;
- // TODO(petewil): Check existing conditions (should be passed down from
- // BackgroundTask)
TryNextRequest();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698