Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: components/feedback/feedback_util.cc

Issue 2189353003: Sent feedback reports must respect the product ID if any was provided (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Devlin's comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/feedback/feedback_util.cc
diff --git a/components/feedback/feedback_util.cc b/components/feedback/feedback_util.cc
index 61f43e3fa756b04158fcf9258860a26ef3e6ef1d..aa2615c3bd88a6c15e45201986fcb4feae4c7cfc 100644
--- a/components/feedback/feedback_util.cc
+++ b/components/feedback/feedback_util.cc
@@ -12,24 +12,11 @@
#include "components/feedback/feedback_data.h"
#include "components/feedback/feedback_uploader.h"
#include "components/feedback/feedback_uploader_factory.h"
-#include "components/feedback/proto/common.pb.h"
-#include "components/feedback/proto/dom.pb.h"
#include "components/feedback/proto/extension.pb.h"
-#include "components/feedback/proto/math.pb.h"
#include "third_party/zlib/google/zip.h"
using feedback::FeedbackData;
-namespace {
-
-#if defined(OS_CHROMEOS)
-const int kChromeOSProductId = 208;
-#else
-const int kChromeBrowserProductId = 237;
-#endif
-
-} // namespace
-
namespace feedback_util {
void SendReport(scoped_refptr<FeedbackData> data) {
@@ -42,28 +29,6 @@ void SendReport(scoped_refptr<FeedbackData> data) {
userfeedback::ExtensionSubmit feedback_data;
data->PrepareReport(&feedback_data);
- // Set whether we're reporting from ChromeOS or Chrome on another platform.
- userfeedback::ChromeData chrome_data;
-#if defined(OS_CHROMEOS)
- chrome_data.set_chrome_platform(
- userfeedback::ChromeData_ChromePlatform_CHROME_OS);
- userfeedback::ChromeOsData chrome_os_data;
- chrome_os_data.set_category(
- userfeedback::ChromeOsData_ChromeOsCategory_OTHER);
- *(chrome_data.mutable_chrome_os_data()) = chrome_os_data;
- feedback_data.set_product_id(kChromeOSProductId);
-#else
- chrome_data.set_chrome_platform(
- userfeedback::ChromeData_ChromePlatform_CHROME_BROWSER);
- userfeedback::ChromeBrowserData chrome_browser_data;
- chrome_browser_data.set_category(
- userfeedback::ChromeBrowserData_ChromeBrowserCategory_OTHER);
- *(chrome_data.mutable_chrome_browser_data()) = chrome_browser_data;
- feedback_data.set_product_id(kChromeBrowserProductId);
-#endif
-
- *(feedback_data.mutable_chrome_data()) = chrome_data;
-
// This pointer will eventually get deleted by the PostCleanup class, after
// we've either managed to successfully upload the report or died trying.
std::string post_body;
@@ -84,8 +49,9 @@ bool ZipString(const base::FilePath& filename,
if (!base::CreateNewTempDirectory(base::FilePath::StringType(), &temp_path))
return false;
if (base::WriteFile(temp_path.Append(filename), data.c_str(), data.size()) ==
- -1)
+ -1) {
return false;
+ }
bool succeed = base::CreateTemporaryFile(&zip_file) &&
zip::Zip(temp_path, zip_file, false) &&

Powered by Google App Engine
This is Rietveld 408576698