Sent feedback reports must respect the product ID if any was provided

chrome/common/extensions/api/feedback_private.idl

Index: chrome/common/extensions/api/feedback_private.idl
diff --git a/chrome/common/extensions/api/feedback_private.idl b/chrome/common/extensions/api/feedback_private.idl
index 2d6e4b3b1c9546baa7735fa8186b0ce96ce9d1cb..c16a6124485e7eb9fa241c19049f97eef3fe5066 100644
--- a/chrome/common/extensions/api/feedback_private.idl
+++ b/chrome/common/extensions/api/feedback_private.idl
@@ -48,7 +48,7 @@ namespace feedbackPrivate {
 
     // Optional product ID to override the Chrome [OS] product id that is
     // usually passed to the feedback server.
-    DOMString? productId;
+    long? productId;

[Devlin, 2016/08/03 22:11:50]

Just FYI, we do actually support choices in APIs (in order to be able to say
string | long).  They're kind of a pain, so if we can be deterministic about it,
it's usually better, but just in case you need it in the future.

[rkc, 2016/08/03 22:21:03]

Ahmed and I had discussed leaving this as a string and just handling it on our
side. With the new kiosk permission though, and this API being a candidate, we
want to fix this and make it clear to the users that this 'needs' to be an
integer.

Since this is a purely whitelisted API at this point, it is something we still
can change, otherwise we'll forever be stuck with a productId that can be either
an integer or a string.

[afakhry, 2016/08/03 22:22:40]

Thanks! Is there any documentation for the supported features in IDL files that
I can keep for reference?

[Devlin, 2016/08/03 22:24:02]

Sadly, no.  At some point, I should write some up, but haven't had the time yet.

 
     // Screenshot to send with this feedback.
     [instanceOf=Blob] object? screenshot;