Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: components/feedback/feedback_common.h

Issue 2189353003: Sent feedback reports must respect the product ID if any was provided (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Devlin's comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/feedback/feedback_common.h
diff --git a/components/feedback/feedback_common.h b/components/feedback/feedback_common.h
index fadb6bf38a4c6dee510e7b9784b3c3b3955520c2..7c6d56da19e5063843cf083f32fc029443c1a1bb 100644
--- a/components/feedback/feedback_common.h
+++ b/components/feedback/feedback_common.h
@@ -100,12 +100,15 @@ class FeedbackCommon : public base::RefCountedThreadSafe<FeedbackCommon> {
void set_locale(const std::string& locale) { locale_ = locale; }
protected:
+ virtual ~FeedbackCommon();
+
+ private:
friend class base::RefCountedThreadSafe<FeedbackCommon>;
friend class FeedbackCommonTest;
- virtual ~FeedbackCommon();
+ // Returns true if a product ID was set in the feedback report.
+ bool HasProductId() const { return product_id_ != -1; }
- private:
std::string category_tag_;
std::string page_url_;
std::string description_;

Powered by Google App Engine
This is Rietveld 408576698