Sent feedback reports must respect the product ID if any was provided

chrome/common/extensions/api/feedback_private.idl

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Use the <code>chrome.feedbackPrivate</code> API to provide Chrome [OS]
 // feedback to the Google Feedback servers.
 namespace feedbackPrivate {
 
   dictionary AttachedFile {
     DOMString name;
@@ skipping 30 matching lines @@
     DOMString description;
 
     // The e-mail of the user that initiated this feedback.
     DOMString? email;
 
     // The URL of the page that this issue was being experienced on.
     DOMString? pageUrl;
 
     // Optional product ID to override the Chrome [OS] product id that is
     // usually passed to the feedback server.
-    DOMString? productId;
+    long? productId;

[Devlin, 2016/08/03 22:11:50]

Just FYI, we do actually support choices in APIs (in order to be able to say
string | long).  They're kind of a pain, so if we can be deterministic about it,
it's usually better, but just in case you need it in the future.

[rkc, 2016/08/03 22:21:03]

Ahmed and I had discussed leaving this as a string and just handling it on our
side. With the new kiosk permission though, and this API being a candidate, we
want to fix this and make it clear to the users that this 'needs' to be an
integer.

Since this is a purely whitelisted API at this point, it is something we still
can change, otherwise we'll forever be stuck with a productId that can be either
an integer or a string.

[afakhry, 2016/08/03 22:22:40]

Thanks! Is there any documentation for the supported features in IDL files that
I can keep for reference?

[Devlin, 2016/08/03 22:24:02]

Sadly, no.  At some point, I should write some up, but haven't had the time yet.

 
     // Screenshot to send with this feedback.
     [instanceOf=Blob] object? screenshot;
 
     // Optional id for performance trace data that can be included in this
     // report.
     long? traceId;
 
     // An array of key/value pairs providing system information for this
     // feedback report.
@@ skipping 54 matching lines @@
   };
 
   interface Events {
     // Fired when the a user requests the launch of the feedback UI. We're
     // using an event for this versus using the override API since we want
     // to be invoked, but not showing a UI, so the feedback extension can
     // take a screenshot of the user's desktop.
     static void onFeedbackRequested(FeedbackInfo feedback);
   };
 };